Bug 47478 - Add 'didDraw' callback to WebKit for framerate tracking
Summary: Add 'didDraw' callback to WebKit for framerate tracking
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-10 19:25 PDT by Simon Fraser (smfr)
Modified: 2013-10-03 11:57 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.77 KB, patch)
2010-10-12 13:56 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (4.99 KB, patch)
2010-10-15 15:09 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (5.68 KB, patch)
2010-10-15 15:20 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-10-10 19:25:19 PDT 
In order to track the rate at which the WebView is drawing to the screen, we need a 'didDraw' callback.
Comment 1 Simon Fraser (smfr) 2010-10-12 13:56:23 PDT 
Created attachment 70562 [details]
Patch
Comment 2 Simon Fraser (smfr) 2010-10-12 14:07:53 PDT 
http://trac.webkit.org/changeset/69600 for Mac.

Keeping open for Windows and WebKit2.
Comment 3 Eric Seidel (no email) 2010-10-14 07:19:32 PDT 
Comment on attachment 70562 [details]
Patch

Cleared Sam Weinig's review+ from obsolete attachment 70562 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 4 Simon Fraser (smfr) 2010-10-15 15:09:07 PDT 
Created attachment 70903 [details]
Patch
Comment 5 WebKit Review Bot 2010-10-15 15:12:03 PDT 
Attachment 70903 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKPage.h:163:  Extra space between WKPageDidDraw and didDraw  [whitespace/declaration] [3]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Early Warning System Bot 2010-10-15 15:16:54 PDT 
Attachment 70903 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4456051
Comment 7 Simon Fraser (smfr) 2010-10-15 15:20:12 PDT 
Created attachment 70905 [details]
Patch
Comment 8 Simon Fraser (smfr) 2010-10-15 15:35:07 PDT 
Comment on attachment 70905 [details]
Patch

http://trac.webkit.org/changeset/69892
Comment 9 Simon Fraser (smfr) 2010-10-15 15:36:16 PDT 
Keep open for Windows.
Comment 10 Adam Barth 2010-10-18 15:55:50 PDT 
To be clear, this is for the embedder, not for JavaScript, right?
Comment 11 Simon Fraser (smfr) 2010-10-18 16:35:19 PDT 
Correct.
Comment 12 Alexey Proskuryakov 2013-10-03 11:57:13 PDT 
Is this still needed?