... that way we can share the same expected result to all platforms.
Created attachment 70425 [details] (committed r69489, r=kling) patch v1 Patch converts the editing/selection/click-in-margins-inside-editable-div to make use of the LayoutTestController::setEditingBehavior machinary. That way, all platform specific editing behavior code paths can be test in the same execution, and we make it possible to share the same expected result file through all ports.
Ossy, could double check if patch is ok on qt buildbots, please?
(In reply to comment #2) > Ossy, could double check if patch is ok on qt buildbots, please? Done. It works for me.
Comment on attachment 70425 [details] (committed r69489, r=kling) patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=70425&action=review > LayoutTests/ChangeLog:9 > + LayoutTestController::setEditingBehavior machinary. That way, all platform specific editing behavior s/machinary/machinery/ > LayoutTests/editing/selection/script-tests/click-in-margins-inside-editable-div.js:71 > // Later we could break this into two tests, one that tests each platform's rules, > // since this is supported as a setting in the Settings object, but for now we'll > // just use separate expected results for Mac and other platforms. Seems like this comment should be removed now.
Comment on attachment 70425 [details] (committed r69489, r=kling) patch v1 Clearing flags on attachment: 70425. Committed r69489: <http://trac.webkit.org/changeset/69489>
(In reply to comment #3) > (In reply to comment #2) > > Ossy, could double check if patch is ok on qt buildbots, please? > Done. It works for me. Thank you for the help.