RESOLVED FIXED 47468
editing/selection/extend-after-mouse-selection.html should use LayoutTestController::setEditingBehavior 
https://bugs.webkit.org/show_bug.cgi?id=47468
Summary editing/selection/extend-after-mouse-selection.html should use LayoutTestCont...
Antonio Gomes
Reported 2010-10-10 04:42:41 PDT
That way we could get rid of platform specific expected result files: $ find . -name extend-after-mouse-selection*./editing/selection/extend-after-mouse-selection.html ./platform/gtk/editing/selection/extend-after-mouse-selection-expected.txt ./platform/mac/editing/selection/extend-after-mouse-selection-expected.txt ./platform/win/editing/selection/extend-after-mouse-selection-expected.txt
Attachments
(committed r69466, r=kling) patch v1 (9.02 KB, patch)
2010-10-10 05:45 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2010-10-10 05:45:23 PDT
Created attachment 70395 [details] (committed r69466, r=kling) patch v1 Patch changed editing/selection/extend-after-mouse-selection.html to use the LayoutTestController::setEditingBehavior machinary. It makes it possible to remove platform dependent test results by testing through all platform-specific codepath's we have.
Andreas Kling
Comment 2 2010-10-10 05:56:46 PDT
Comment on attachment 70395 [details] (committed r69466, r=kling) patch v1 LGTM
Antonio Gomes
Comment 3 2010-10-10 08:28:37 PDT
Comment on attachment 70395 [details] (committed r69466, r=kling) patch v1 Clearing review flags on attachment: 70395. Committed r69466: http://trac.webkit.org/changeset/69466
Note You need to log in before you can comment on or make changes to this bug.