Bug 47455 - [Qt] Compile fails when building qtwebkit with the "--v8" option...
Summary: [Qt] Compile fails when building qtwebkit with the "--v8" option...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-09 13:07 PDT by Dawit A.
Modified: 2010-10-14 12:23 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch to fix compile issue... (923 bytes, patch)
2010-10-09 13:09 PDT, Dawit A.
kling: review-
Details | Formatted Diff | Diff
Proposed patch [Update 1]... (1.02 KB, patch)
2010-10-09 13:20 PDT, Dawit A.
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dawit A. 2010-10-09 13:07:18 PDT
Because of the following #include sequence in the generated webkit v8 source files:
V8Proxy.h -> PlatformBridge.h -> npapi.h -> Xlib.h -> X.h

That sequence leads to the word "None" being defined as 


#ifndef None
#define None                 0L /* universal null resource or null atom */
#endif

in X.h. Unfortunately that leads to the "None" in "v8::None" enum values being changed to v8::0L by the gcc preprocessor...
Comment 1 Dawit A. 2010-10-09 13:09:29 PDT
Created attachment 70366 [details]
Proposed patch to fix compile issue...
Comment 2 Andreas Kling 2010-10-09 13:20:44 PDT
Comment on attachment 70366 [details]
Proposed patch to fix compile issue...

View in context: https://bugs.webkit.org/attachment.cgi?id=70366&action=review

> WebCore/platform/qt/PlatformBridge.h:80
>  class NPObject;
> +class NPP;

Snag this from ChromiumBridge.h instead:

typedef struct NPObject NPObject;
typedef struct _NPP NPP_t;
typedef NPP_t* NPP;
Comment 3 Dawit A. 2010-10-09 13:20:48 PDT
Created attachment 70368 [details]
Proposed patch [Update 1]...
Comment 4 Andreas Kling 2010-10-09 13:24:09 PDT
Comment on attachment 70368 [details]
Proposed patch [Update 1]...

r=me
Comment 5 WebKit Commit Bot 2010-10-14 12:22:58 PDT
Comment on attachment 70368 [details]
Proposed patch [Update 1]...

Clearing flags on attachment: 70368

Committed r69791: <http://trac.webkit.org/changeset/69791>
Comment 6 WebKit Commit Bot 2010-10-14 12:23:07 PDT
All reviewed patches have been landed.  Closing bug.