Bug 47454 - FileWriter sends write event instead of progress event
Summary: FileWriter sends write event instead of progress event
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Eric U.
Depends on:
Blocks: 44358
  Show dependency treegraph
Reported: 2010-10-09 10:53 PDT by Eric U.
Modified: 2010-10-09 19:16 PDT (History)
4 users (show)

See Also:

Patch (1.28 KB, patch)
2010-10-09 17:21 PDT, Eric U.
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric U. 2010-10-09 10:53:40 PDT
The FileWriter is currently sending the write event where it should be sending a progress event.
Write happens only at the end of a successful truncate or write, whereas progress happens throughout an ongoing write.
Comment 1 Eric U. 2010-10-09 17:21:45 PDT
Created attachment 70381 [details]
Comment 2 Andreas Kling 2010-10-09 18:55:51 PDT
Comment on attachment 70381 [details]

According to the spec, readyState should be DONE when the "write" event fires:
http://www.w3.org/TR/file-writer-api/#widl-FileWriter-write  (steps 6, 7 and 8.)
Comment 3 Andreas Kling 2010-10-09 18:59:18 PDT
Comment on attachment 70381 [details]

D'oh, that's my bad. I was looking at an outdated version of the spec.

Here's the relevant one:

Comment 4 WebKit Commit Bot 2010-10-09 19:16:11 PDT
Comment on attachment 70381 [details]

Clearing flags on attachment: 70381

Committed r69463: <http://trac.webkit.org/changeset/69463>
Comment 5 WebKit Commit Bot 2010-10-09 19:16:16 PDT
All reviewed patches have been landed.  Closing bug.