Bug 47441 - [GTK] Search field icons should be centered vertically in the field
Summary: [GTK] Search field icons should be centered vertically in the field
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2010-10-08 16:46 PDT by Martin Robinson
Modified: 2010-10-11 08:24 PDT (History)
1 user (show)

See Also:

Attachments
Search field icon that is not centered (5.34 KB, image/png)
2010-10-08 16:47 PDT, Martin Robinson 		no flags Details
Patch for this issue (17.49 KB, patch)
2010-10-08 17:00 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch clarifying rounding and reducing duplicated code (17.61 KB, patch)
2010-10-09 13:29 PDT, Martin Robinson 		xan.lopez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-10-08 16:46:03 PDT 
Currently search field icons seem to be drawn at some fixed distance from the top of the text field. See attached screenshot for demonstration of the issue.
Comment 1 Martin Robinson 2010-10-08 16:47:19 PDT 
Created attachment 70317 [details]
Search field icon that is not centered
Comment 2 Martin Robinson 2010-10-08 17:00:29 PDT 
Created attachment 70319 [details]
Patch for this issue
Comment 3 Xan Lopez 2010-10-09 02:43:34 PDT 
Comment on attachment 70319 [details]
Patch for this issue

View in context: https://bugs.webkit.org/attachment.cgi?id=70319&action=review

> WebCore/platform/gtk/RenderThemeGtk.cpp:528
> +    }

What's the + 1 for? :)
Comment 4 Martin Robinson 2010-10-09 08:20:18 PDT 
For text boxes with height that are an even number of pixels, it rounds to the bottom of the two central pixels. It originates from the Chromium port and they had a comment about this, so I definitely need to add one here. I will. :)
Comment 5 Martin Robinson 2010-10-09 13:29:45 PDT 
Created attachment 70369 [details]
Patch clarifying rounding and reducing duplicated code
Comment 6 Martin Robinson 2010-10-11 08:24:42 PDT 
Committed r69495: <http://trac.webkit.org/changeset/69495>