Bug 47435 - [GTK] Slider padding translate into a larger track rect
Summary: [GTK] Slider padding translate into a larger track rect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2010-10-08 15:55 PDT by Martin Robinson
Modified: 2010-10-09 08:17 PDT (History)
0 users

See Also:

Attachments
Screenshot showing padding issue (5.04 KB, image/png)
2010-10-08 15:56 PDT, Martin Robinson 		no flags Details
Patch for this issue (6.32 KB, patch)
2010-10-08 16:01 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-10-08 15:55:31 PDT 
When a range widget has padding, the padding is added to the track rect drawing area. For some themes this results in wildy incorrect rendering. See attached render.
Comment 1 Martin Robinson 2010-10-08 15:56:24 PDT 
Created attachment 70307 [details]
Screenshot showing padding issue
Comment 2 Martin Robinson 2010-10-08 16:01:36 PDT 
Created attachment 70310 [details]
Patch for this issue
Comment 3 Martin Robinson 2010-10-08 16:02:42 PDT 
I've uploaded a patch for this issue. The rectangle size is still not entirely correct (we should be getting some padding values from the widget style to inflate the track rect), but with this patch it is much closer.
Comment 4 Martin Robinson 2010-10-09 08:17:33 PDT 
Comment on attachment 70310 [details]
Patch for this issue

Clearing flags on attachment: 70310

Committed r69447: <http://trac.webkit.org/changeset/69447>
Comment 5 Martin Robinson 2010-10-09 08:17:37 PDT 
All reviewed patches have been landed.  Closing bug.