Bug 47431 - <a ping> tests are slow
Summary: <a ping> tests are slow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-08 14:35 PDT by Mihai Parparita
Modified: 2010-10-10 12:46 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2010-10-08 14:42 PDT, Mihai Parparita 		no flags Details | Formatted Diff | Diff
Patch (3.64 KB, patch)
2010-10-09 09:34 PDT, Mihai Parparita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-10-08 14:35:54 PDT 
<a ping> tests are slow/flaky
Comment 1 Mihai Parparita 2010-10-08 14:42:13 PDT 
Created attachment 70291 [details]
Patch
Comment 2 WebKit Commit Bot 2010-10-08 16:49:24 PDT 
Comment on attachment 70291 [details]
Patch

Rejecting patch 70291 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2
Last 500 characters of output:
Files=14, Tests=304,  1 wallclock secs ( 0.72 cusr +  0.17 csys =  0.89 CPU)
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Projects/CommitQueue/LayoutTests
Testing 21521 test cases.
http/tests/navigation/image-load-in-unload-handler.html -> failed

Exiting early after 1 failures. 20813 tests run.
515.26s total testing time

20812 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
34 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/4312001
Comment 3 Mihai Parparita 2010-10-09 05:48:42 PDT 
image-load-in-unload-handler.html may be flaky, trying again.
Comment 4 WebKit Commit Bot 2010-10-09 06:20:16 PDT 
Comment on attachment 70291 [details]
Patch

Rejecting patch 70291 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2
Last 500 characters of output:
 Tests=304,  1 wallclock secs ( 0.64 cusr +  0.13 csys =  0.77 CPU)
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/abarth/git/webkit-queue/LayoutTests
Testing 21522 test cases.
http/tests/navigation/image-load-in-unload-handler.html -> failed

Exiting early after 1 failures. 20814 tests run.
482.52s total testing time

20813 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
34 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/4278006
Comment 5 Mihai Parparita 2010-10-09 08:44:29 PDT 
Guess it is my fault, that test uses the check-ping.php scrip too. Will investigate.
Comment 6 Mihai Parparita 2010-10-09 09:34:52 PDT 
Created attachment 70353 [details]
Patch

The change to not have check-ping.php return with a Refresh header caused a race condition in image-load-in-unload-handler.html; this should fix that.
Comment 7 WebKit Commit Bot 2010-10-10 12:46:26 PDT 
Comment on attachment 70353 [details]
Patch

Clearing flags on attachment: 70353

Committed r69469: <http://trac.webkit.org/changeset/69469>
Comment 8 WebKit Commit Bot 2010-10-10 12:46:33 PDT 
All reviewed patches have been landed.  Closing bug.