Bug 47431 – <a ping> tests are slow

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Mihai Parparita]

<a ping> tests are slow/flaky

[Mihai Parparita]

Created attachment 70291 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 70291 [details]
Patch

Rejecting patch 70291 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2
Last 500 characters of output:
Files=14, Tests=304,  1 wallclock secs ( 0.72 cusr +  0.17 csys =  0.89 CPU)
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Projects/CommitQueue/LayoutTests
Testing 21521 test cases.
http/tests/navigation/image-load-in-unload-handler.html -> failed

Exiting early after 1 failures. 20813 tests run.
515.26s total testing time

20812 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
34 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/4312001

[Mihai Parparita]

image-load-in-unload-handler.html may be flaky, trying again.

[WebKit Commit Bot]

Comment on attachment 70291 [details]
Patch

Rejecting patch 70291 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2
Last 500 characters of output:
 Tests=304,  1 wallclock secs ( 0.64 cusr +  0.13 csys =  0.77 CPU)
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/abarth/git/webkit-queue/LayoutTests
Testing 21522 test cases.
http/tests/navigation/image-load-in-unload-handler.html -> failed

Exiting early after 1 failures. 20814 tests run.
482.52s total testing time

20813 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
34 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/4278006

[Mihai Parparita]

Guess it is my fault, that test uses the check-ping.php scrip too. Will investigate.

[Mihai Parparita]

Created attachment 70353 [details]
Patch

The change to not have check-ping.php return with a Refresh header caused a race condition in image-load-in-unload-handler.html; this should fix that.

[WebKit Commit Bot]

Comment on attachment 70353 [details]
Patch

Clearing flags on attachment: 70353

Committed r69469: <http://trac.webkit.org/changeset/69469>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.