Bug 47420 - Language tag in speech for HTML input elements postpatch
Summary: Language tag in speech for HTML input elements postpatch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Leandro Graciá Gil
URL:
Keywords:
Depends on:
Blocks: 47089
  Show dependency treegraph
 
Reported: 2010-10-08 09:25 PDT by Leandro Graciá Gil
Modified: 2012-09-19 07:16 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.78 KB, patch)
2010-10-13 05:32 PDT, Leandro Graciá Gil
no flags Details | Formatted Diff | Diff
Patch (5.07 KB, patch)
2010-10-29 08:48 PDT, Leandro Graciá Gil
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leandro Graciá Gil 2010-10-08 09:25:54 PDT
This is the last part of a 4-sided patch. The patch proposed for bug https://bugs.webkit.org/show_bug.cgi?id=47089 introduces a few temporary fixes required to avoid crashing chromium. This patch removes them, and will be applied after all the other chromium parts.

For more information on this 4-sided patch visit:
- 1st part: http://codereview.chromium.org/3615005/show
- 2nd part: https://bugs.webkit.org/show_bug.cgi?id=47089
- 3rd part: http://codereview.chromium.org/3595018/show
Comment 1 Leandro Graciá Gil 2010-10-13 05:32:18 PDT
Created attachment 70601 [details]
Patch
Comment 2 Leandro Graciá Gil 2010-10-29 08:48:23 PDT
Created attachment 72340 [details]
Patch
Comment 3 Satish Sampath 2010-10-29 08:51:20 PDT
Comment on attachment 72340 [details]
Patch

Looks good to me
Comment 4 Jeremy Orlow 2010-10-29 08:57:45 PDT
Comment on attachment 72340 [details]
Patch

r=me
Comment 5 Satish Sampath 2010-10-29 09:04:13 PDT
Comment on attachment 72340 [details]
Patch

Removing cq+ as the chromium side needs to roll past the previous webkit patch.
Comment 6 WebKit Commit Bot 2010-10-29 09:43:25 PDT
The commit-queue encountered the following flaky tests while processing attachment 72340 [details]:

webarchive/test-link-rel-icon.html

Please file bugs against the tests.  These tests were authored by ddkilzer@webkit.org.  The commit-queue is continuing to process your patch.
Comment 7 Leandro Graciá Gil 2010-11-01 05:44:15 PDT
Comment on attachment 72340 [details]
Patch

Chromium side patch landed. Now it should be safe to land this one.
Comment 8 Satish Sampath 2010-11-01 05:56:28 PDT
Comment on attachment 72340 [details]
Patch

Clearing flags on attachment: 72340

Committed r71019: <http://trac.webkit.org/changeset/71019>
Comment 9 Satish Sampath 2010-11-01 05:56:37 PDT
All reviewed patches have been landed.  Closing bug.