Bug 47415 – Web Inspector: extract content-related methods into InspectorResourceAgent.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

This is needed for resource-tracking-less operation of resources panel.

[Pavel Feldman]

Created attachment 70244 [details]
[PATCH] Proposed change.

[WebKit Review Bot]

Attachment 70244 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/inspector/InspectorResourceAgent.cpp:137:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
WebCore/inspector/InspectorResourceAgent.cpp:121:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 10 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Pavel Feldman]

Created attachment 70246 [details]
[PATCH] With good style.

[Eric Seidel (no email)]

Attachment 70244 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4228136

[WebKit Review Bot]

Attachment 70246 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/inspector/InspectorResourceAgent.cpp:121:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Pavel Feldman]

Created attachment 70247 [details]
[PATCH] With project files too!

[Eric Seidel (no email)]

Attachment 70246 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4179134

[Eric Seidel (no email)]

Attachment 70247 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4143136

[Yury Semikhatsky]

Comment on attachment 70246 [details]
[PATCH] With good style.

View in context: https://bugs.webkit.org/attachment.cgi?id=70246&action=review

> WebCore/inspector/InspectorResource.cpp:-457
> -    if (m_loader && equalIgnoringFragmentIdentifier(m_requestURL, m_loader->requestURL())) {

The m_loader field should go away completely.

> WebCore/inspector/InspectorResourceAgent.cpp:90
> +    if (equalIgnoringFragmentIdentifier(url, loader->url())) {

Should this be assert? We seem to prune resource when the document loader changes.

> WebCore/inspector/InspectorResourceAgent.h:2
> + * Copyright (C) 2009 Google Inc. All rights reserved.

2010

[Yury Semikhatsky]

Comment on attachment 70247 [details]
[PATCH] With project files too!

View in context: https://bugs.webkit.org/attachment.cgi?id=70247&action=review

> WebCore/WebCore.xcodeproj/project.pbxproj:12213
> +				82AB1771125C826700C5069D /* InspectorResourceAgent.cpp */,

Mind alphabetic order here.

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        R       WebCore/inspector/InspectorUtilities.h => WebCore/inspector/InspectorResourceAgent.h
        D       WebCore/inspector/InspectorUtilities.cpp
        M       WebCore/CMakeLists.txt
        M       WebCore/ChangeLog
        M       WebCore/GNUmakefile.am
        M       WebCore/WebCore.gypi
        M       WebCore/WebCore.pro
        M       WebCore/WebCore.vcproj/WebCore.vcproj
        M       WebCore/WebCore.xcodeproj/project.pbxproj
        M       WebCore/inspector/InspectorCSSAgent.cpp
        M       WebCore/inspector/InspectorResource.cpp
        M       WebCore/inspector/InspectorResource.h
        A       WebCore/inspector/InspectorResourceAgent.cpp
        M       WebCore/inspector/InspectorStyleSheet.cpp
Committed r69757

[WebKit Review Bot]

http://trac.webkit.org/changeset/69757 might have broken Chromium Mac Release