Bug 47406 - Web Inspector: save InspectorController in instrumentation cookie
Summary: Web Inspector: save InspectorController in instrumentation cookie
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-08 03:49 PDT by Pavel Podivilov
Modified: 2010-10-08 09:41 PDT (History)
15 users (show)

See Also:


Attachments
Patch. (43.74 KB, patch)
2010-10-08 03:50 PDT, Pavel Podivilov
no flags Details | Formatted Diff | Diff
Patch. (43.97 KB, patch)
2010-10-08 03:59 PDT, Pavel Podivilov
no flags Details | Formatted Diff | Diff
Fix build. (44.71 KB, patch)
2010-10-08 04:10 PDT, Pavel Podivilov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2010-10-08 03:49:25 PDT
Web Inspector: save InspectorController in instrumentation cookie
Comment 1 Pavel Podivilov 2010-10-08 03:50:52 PDT
Created attachment 70222 [details]
Patch.
Comment 2 Pavel Podivilov 2010-10-08 03:59:33 PDT
Created attachment 70223 [details]
Patch.
Comment 3 Early Warning System Bot 2010-10-08 04:00:01 PDT
Attachment 70222 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4271001
Comment 4 WebKit Review Bot 2010-10-08 04:00:24 PDT
Attachment 70222 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/4184144
Comment 5 Eric Seidel (no email) 2010-10-08 04:04:45 PDT
Attachment 70222 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4269013
Comment 6 WebKit Review Bot 2010-10-08 04:07:15 PDT
Attachment 70223 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/4171127
Comment 7 Early Warning System Bot 2010-10-08 04:07:52 PDT
Attachment 70223 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4166134
Comment 8 Pavel Podivilov 2010-10-08 04:10:24 PDT
Created attachment 70224 [details]
Fix build.
Comment 9 Eric Seidel (no email) 2010-10-08 04:12:28 PDT
Attachment 70223 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4220141
Comment 10 Pavel Feldman 2010-10-08 08:26:52 PDT
Comment on attachment 70224 [details]
Fix build.

View in context: https://bugs.webkit.org/attachment.cgi?id=70224&action=review

> WebCore/bindings/v8/V8Proxy.cpp:502
> +        InspectorInstrumentationCookie cookie = InspectorInstrumentationCookie();

InspectorInstrumentationCookie cookie;
Comment 11 Pavel Podivilov 2010-10-08 09:41:20 PDT
Committed r69406: <http://trac.webkit.org/changeset/69406>