Bug 47402 - [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
Summary: [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Andras Becsi
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-10-08 03:05 PDT by Andras Becsi
Modified: 2010-10-08 05:30 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (4.44 KB, patch)
2010-10-08 03:19 PDT, Andras Becsi 		no flags Details | Formatted Diff | Diff
proposed patch (4.44 KB, patch)
2010-10-08 03:41 PDT, Andras Becsi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2010-10-08 03:05:53 PDT 
Add missing implementation of WTR::activateFonts() to WebKitTestRunner's InjectedBundle.
Comment 1 Andras Becsi 2010-10-08 03:19:30 PDT 
Created attachment 70218 [details]
proposed patch

Add missing file which was already added to the project file in a previous stage of the upstreaming.
Comment 2 WebKit Review Bot 2010-10-08 03:26:13 PDT 
Attachment 70218 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:30:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:69:  Declaration has space between type name and * in FcConfig *config  [whitespace/declaration] [3]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andras Becsi 2010-10-08 03:41:18 PDT 
Created attachment 70220 [details]
proposed patch

Fixed the misplaced * and WebKit2 does not a config.h.
Comment 4 WebKit Review Bot 2010-10-08 03:49:35 PDT 
Attachment 70220 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:30:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Kenneth Rohde Christiansen 2010-10-08 04:35:28 PDT 
Comment on attachment 70220 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70220&action=review

> WebKitTools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:43
> +{
> +

unneeded newline here

> WebKitTools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:81
> +
> +}

Here as well
Comment 6 Andras Becsi 2010-10-08 05:29:40 PDT 
Committed r69392: <http://trac.webkit.org/changeset/69392>
Comment 7 Andras Becsi 2010-10-08 05:30:30 PDT 
Comment on attachment 70220 [details]
proposed patch

Clearing flags.