Bug 47393 - More StringImpl / String 64-bit cleanliness issues
Summary: More StringImpl / String 64-bit cleanliness issues
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Chris Evans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-07 19:11 PDT by Chris Evans
Modified: 2010-10-08 12:38 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.78 KB, patch)
2010-10-07 19:20 PDT, Chris Evans
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Evans 2010-10-07 19:11:20 PDT
I saw a few more issues whilst fixing some unrelated things. I think it's best I describe the bugs with a patch to be honest. Most of the issues are size_t vs. unsigned confusion on 64-bit, but also a couple of cases where it looks prudent to check for integer overflows.

Patch forthcoming.
Comment 1 Chris Evans 2010-10-07 19:20:53 PDT
Created attachment 70188 [details]
Patch
Comment 2 WebKit Commit Bot 2010-10-08 12:38:23 PDT
Comment on attachment 70188 [details]
Patch

Clearing flags on attachment: 70188

Committed r69414: <http://trac.webkit.org/changeset/69414>
Comment 3 WebKit Commit Bot 2010-10-08 12:38:28 PDT
All reviewed patches have been landed.  Closing bug.