WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
47393
More StringImpl / String 64-bit cleanliness issues
https://bugs.webkit.org/show_bug.cgi?id=47393
Summary
More StringImpl / String 64-bit cleanliness issues
Chris Evans
Reported
2010-10-07 19:11:20 PDT
I saw a few more issues whilst fixing some unrelated things. I think it's best I describe the bugs with a patch to be honest. Most of the issues are size_t vs. unsigned confusion on 64-bit, but also a couple of cases where it looks prudent to check for integer overflows. Patch forthcoming.
Attachments
Patch
(3.78 KB, patch)
2010-10-07 19:20 PDT
,
Chris Evans
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Evans
Comment 1
2010-10-07 19:20:53 PDT
Created
attachment 70188
[details]
Patch
WebKit Commit Bot
Comment 2
2010-10-08 12:38:23 PDT
Comment on
attachment 70188
[details]
Patch Clearing flags on attachment: 70188 Committed
r69414
: <
http://trac.webkit.org/changeset/69414
>
WebKit Commit Bot
Comment 3
2010-10-08 12:38:28 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug