Bug 47389 – IndexedDB does not have a quota mechanism.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andrei Popescu]

IndexedDB does not have a quota mechanism.

[Andrei Popescu]

Created attachment 70184 [details]
Patch

[WebKit Review Bot]

Attachment 70184 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/storage/IDBDatabaseBackendImpl.cpp:156:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jeremy Orlow]

Comment on attachment 70184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70184&action=review

close

> LayoutTests/storage/indexeddb/database-basics.html:124
> +function checkQuotaEnforcing()

I think this stuff would be best in its own test.

> WebCore/storage/IDBDatabaseBackendImpl.cpp:155
> +        transaction->abort();

return?

> WebCore/storage/IDBDatabaseBackendImpl.cpp:230
> +        callbacks->onError(IDBDatabaseError::create(IDBDatabaseException::UNKNOWN_ERR, "Error writing data to stable storage."));

Add a fixme to spec this.

> WebCore/storage/IDBObjectStoreBackendImpl.cpp:136
> +    return (resultCode != SQLResultOk) && (resultCode != SQLResultDone);

don't need ()'s

When could a result be either one or the other?  Isn't it always defined which it'll be in a non-error case?

> WebCore/storage/IDBObjectStoreBackendImpl.cpp:192
> +    RefPtr<IDBTransactionBackendInterface> transactionPtr = transaction;

um..you put the Ptr suffix in the wrong place  :-)

> WebCore/storage/IDBObjectStoreBackendImpl.cpp:246
> +        callbacks->onError(IDBDatabaseError::create(IDBDatabaseException::UNKNOWN_ERR, "Error writing data to stable storage."));

fixmes...here and anywhere u use unkown_err

> WebKit/chromium/src/WebIDBFactoryImpl.cpp:61
> +void WebIDBFactoryImpl::open(const WebString& name, const WebString& description, WebIDBCallbacks* callbacks, const WebSecurityOrigin& origin, WebFrame*, const WebString& dataDir, unsigned long long maximumSize)

int64 should work, i think.  i'm pretty sure i used it somewhere else in this

[Andrei Popescu]

Created attachment 70272 [details]
Patch

[Jeremy Orlow]

Comment on attachment 70272 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70272&action=review

r=me

> WebCore/storage/IDBObjectStoreBackendImpl.cpp:303
> +    if (!insert.prepare()) {

compare against the constants

> WebCore/storage/IDBObjectStoreBackendImpl.cpp:311
> +    if (!insert.step()) {

compare against the constants

> WebCore/storage/IDBObjectStoreBackendImpl.h:86
> +    static void putInternal(ScriptExecutionContext*, PassRefPtr<IDBObjectStoreBackendImpl>, PassRefPtr<SerializedScriptValue> value, PassRefPtr<IDBKey> key, bool addOnly, PassRefPtr<IDBCallbacks>, PassRefPtr<IDBTransactionBackendInterface> transaction);

don't need the word transaction

[Andrei Popescu]

Committed r69421: <http://trac.webkit.org/changeset/69421>