Bug 47385 - Copy mesa lib into DumpRenderTree bundle in Mac
Summary: Copy mesa lib into DumpRenderTree bundle in Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Zhenyao Mo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-07 17:10 PDT by Zhenyao Mo
Modified: 2010-10-07 17:55 PDT (History)
4 users (show)

See Also:


Attachments
patch (1.97 KB, patch)
2010-10-07 17:12 PDT, Zhenyao Mo
tony: review-
zmo: commit-queue-
Details | Formatted Diff | Diff
revised patch: responding to Tony Chang's review (1.58 KB, patch)
2010-10-07 17:44 PDT, Zhenyao Mo
tony: review+
zmo: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zhenyao Mo 2010-10-07 17:10:01 PDT
Currently the code assumes mesa lib is there (which isn't), so DumpRenderTree is not using Mesa at the moment in Mac
Comment 1 Zhenyao Mo 2010-10-07 17:12:33 PDT
Created attachment 70175 [details]
patch
Comment 2 Tony Chang 2010-10-07 17:24:50 PDT
Comment on attachment 70175 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70175&action=review

> WebKit/chromium/WebKit.gyp:810
> +            'target_name': 'mesa',

Can you move this target to the OS=="mac" section at the bottom of the file (next to LayoutTestHelper)?

> WebKit/chromium/WebKit.gyp:830
> +                'mesa',

And this will then move next to the LayoutTestHelper dependencies (around line 895).

> WebKit/chromium/WebKit.gyp:-819
> -                '<(chromium_src_dir)/third_party/mesa/mesa.gyp:osmesa',

Then you can keep this line since win/linux needs it.
Comment 3 Zhenyao Mo 2010-10-07 17:44:35 PDT
Created attachment 70180 [details]
revised patch: responding to Tony Chang's review

Also, I changed the target name from mesa to copy_mesa
Comment 4 Tony Chang 2010-10-07 17:46:15 PDT
Comment on attachment 70180 [details]
revised patch: responding to Tony Chang's review

LGTM!
Comment 5 Zhenyao Mo 2010-10-07 17:55:03 PDT
Committed r69365: <http://trac.webkit.org/changeset/69365>