Bug 47383 - [EFL] Fix shared timers on EFL port - make them thread safe.
Summary: [EFL] Fix shared timers on EFL port - make them thread safe.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Rafael Antognolli
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-07 16:04 PDT by Rafael Antognolli
Modified: 2010-10-07 17:28 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.00 KB, patch)
2010-10-07 16:14 PDT, Rafael Antognolli 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Antognolli 2010-10-07 16:04:45 PDT 
[EFL] Fix shared timers on EFL port - make them thread safe.
Comment 1 Rafael Antognolli 2010-10-07 16:14:22 PDT 
Created attachment 70165 [details]
Patch
Comment 2 Rafael Antognolli 2010-10-07 16:18:48 PDT 
As explained in the changelog, this patch makes shared timers thread safe for EFL port. I'm not sure about the function names, maybe would be good to use some namespace on them, since they are not methods from a class?

It would be good to get rid of the mutex too, since we just need it when creating the pipe from a thread that is not the main thread. Do you think it's possible to add a function inside ThreadTimers or SharedTimer like initializeSharedTimer (which would be called from the main thread) so we can create the pipe there?
Comment 3 WebKit Commit Bot 2010-10-07 17:28:44 PDT 
Comment on attachment 70165 [details]
Patch

Clearing flags on attachment: 70165

Committed r69358: <http://trac.webkit.org/changeset/69358>
Comment 4 WebKit Commit Bot 2010-10-07 17:28:49 PDT 
All reviewed patches have been landed.  Closing bug.