Bug 47373 - Add a WKPageFindClient, hook up WKPageCountStringMatches
Summary: Add a WKPageFindClient, hook up WKPageCountStringMatches
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-07 13:02 PDT by Anders Carlsson
Modified: 2010-10-07 14:50 PDT (History)
1 user (show)

See Also:

Attachments
Patch (36.76 KB, patch)
2010-10-07 13:07 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-10-07 13:02:56 PDT 
Add a WKPageFindClient, hook up WKPageCountStringMatches
Comment 1 Anders Carlsson 2010-10-07 13:07:53 PDT 
Created attachment 70140 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-07 13:09:32 PDT 
Attachment 70140 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKPage.h:162:  Extra space between int and version  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:164:  Extra space between WKPageDidCountStringMatchesCallback and didCountStringMatches  [whitespace/declaration] [3]
WebKitTools/TestWebKitAPI/Tests/WebKit2/Find.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/TestWebKitAPI/Tests/WebKit2/Find.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
WebKitTools/TestWebKitAPI/Tests/WTF/VectorBasic.cpp:37:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKit2/UIProcess/WebFindClient.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 6 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-10-07 14:50:49 PDT 
Committed r69343: <http://trac.webkit.org/changeset/69343>