Bug 47370 – Make line boxes place themselves correctly in the inline direction.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

Make line boxes place themselves correctly in the inline direction.  This means the y-position for vertical line boxes will now be correct.

[Dave Hyatt]

Created attachment 70135 [details]
Patch

[Sam Weinig]

Comment on attachment 70135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70135&action=review

Looks good other than the & issue.

> WebCore/rendering/style/RenderStyle.h:643
> +    void getTextShadowExtent(int &top, int &right, int &bottom, int &left) const { getShadowExtent(textShadow(), top, right, bottom, left); }
> +    void getTextShadowHorizontalExtent(int &left, int &right) const { getShadowHorizontalExtent(textShadow(), left, right); }
> +    void getTextShadowVerticalExtent(int &top, int &bottom) const { getShadowVerticalExtent(textShadow(), top, bottom); }
> +    void getTextShadowInlineDirectionExtent(int &logicalLeft, int &logicalRight) { getShadowInlineDirectionExtent(textShadow(), logicalLeft, logicalRight); }

The & are on the wrong side.

> WebCore/rendering/style/RenderStyle.h:662
> +    void getBoxShadowExtent(int &top, int &right, int &bottom, int &left) const { getShadowExtent(boxShadow(), top, right, bottom, left); }
> +    void getBoxShadowHorizontalExtent(int &left, int &right) const { getShadowHorizontalExtent(boxShadow(), left, right); }
> +    void getBoxShadowVerticalExtent(int &top, int &bottom) const { getShadowVerticalExtent(boxShadow(), top, bottom); }
> +    void getBoxShadowInlineDirectionExtent(int &logicalLeft, int &logicalRight) { getShadowInlineDirectionExtent(boxShadow(), logicalLeft, logicalRight); }

Here too.

> WebCore/rendering/style/RenderStyle.h:1278
> +    void getShadowExtent(const ShadowData*, int &top, int &right, int &bottom, int &left) const;
> +    void getShadowHorizontalExtent(const ShadowData*, int &left, int &right) const;
> +    void getShadowVerticalExtent(const ShadowData*, int &top, int &bottom) const;
> +    void getShadowInlineDirectionExtent(const ShadowData* shadow, int &logicalLeft, int &logicalRight) const
> +    {
> +        return isHorizontalWritingMode() ? getShadowHorizontalExtent(shadow, logicalLeft, logicalRight) : getShadowVerticalExtent(shadow, logicalLeft, logicalRight);
> +    }

And here.

[Dave Hyatt]

Fixed in r69341.