Bug 47367 - [GTK] Remove duplicate code in WebKit/gtk/WebCoreSupport/DragClientGtk.cpp
Summary: [GTK] Remove duplicate code in WebKit/gtk/WebCoreSupport/DragClientGtk.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2010-10-07 11:41 PDT by Martin Robinson
Modified: 2010-10-08 09:02 PDT (History)
2 users (show)

See Also:

Attachments
Patch for this issue (5.86 KB, patch)
2010-10-07 11:46 PDT, Martin Robinson 		xan.lopez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-10-07 11:41:35 PDT 
r69290 introduced some duplicate code into WebKit/gtk/WebCoreSupport/DragClientGtk.cpp. This bug tracks removing it.
Comment 1 Martin Robinson 2010-10-07 11:46:07 PDT 
Created attachment 70126 [details]
Patch for this issue
Comment 2 Carlos Garcia Campos 2010-10-08 00:01:49 PDT 
In if (!gdk_cairo_get_clip_rectangle(cr, &clipRect)). Since we are not using clipRect and gdk_cairo_get_clip_rectangle() accepts NULL, Xan suggested to use NULL rather than a varaible.
Comment 3 Xan Lopez 2010-10-08 03:13:27 PDT 
Comment on attachment 70126 [details]
Patch for this issue

Looks good to me, you can do what carlos suggests when committing.
Comment 4 Martin Robinson 2010-10-08 09:02:11 PDT 
Thanks for the review. I will make the change before landing.
Comment 5 Martin Robinson 2010-10-08 09:02:37 PDT 
Committed r69403: <http://trac.webkit.org/changeset/69403>