Bug 47360 - Web Inspector: all native breakpoints should inherit from NativeBreakpoint
Summary: Web Inspector: all native breakpoints should inherit from NativeBreakpoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-07 10:19 PDT by Pavel Podivilov
Modified: 2010-10-12 02:36 PDT (History)
10 users (show)

See Also:

Attachments
Patch. (56.31 KB, patch)
2010-10-07 10:25 PDT, Pavel Podivilov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2010-10-07 10:19:29 PDT 
Web Inspector: all native breakpoints should inherit from NativeBreakpoint

DOM, EventListener and XHR breakpoints should be subclasses of NativeBreakpoint. Stuff that depends on breakpoint type, should be implemented in corresponding subclass.
Comment 1 Pavel Podivilov 2010-10-07 10:25:56 PDT 
Created attachment 70112 [details]
Patch.
Comment 2 Pavel Feldman 2010-10-08 08:32:04 PDT 
Comment on attachment 70112 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=70112&action=review

> WebCore/inspector/InspectorDOMAgent.cpp:781
> +    pair<long, long> breakpoint = m_idToBreakpoint.take(breakpointId);

Could you typedef this in header so that we knew what is going on.

> WebCore/inspector/front-end/BreakpointManager.js:138
> +        if (!(nodeId in this._domPathCache))

Please add // FIXME:
Comment 3 Pavel Podivilov 2010-10-12 02:36:00 PDT 
Committed r69567: <http://trac.webkit.org/changeset/69567>