RESOLVED FIXED 47360
Web Inspector: all native breakpoints should inherit from NativeBreakpoint 
https://bugs.webkit.org/show_bug.cgi?id=47360
Summary Web Inspector: all native breakpoints should inherit from NativeBreakpoint
Pavel Podivilov
Reported 2010-10-07 10:19:29 PDT
Web Inspector: all native breakpoints should inherit from NativeBreakpoint DOM, EventListener and XHR breakpoints should be subclasses of NativeBreakpoint. Stuff that depends on breakpoint type, should be implemented in corresponding subclass.
Attachments
Patch. (56.31 KB, patch)
2010-10-07 10:25 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2010-10-07 10:25:56 PDT
Created attachment 70112 [details] Patch.
Pavel Feldman
Comment 2 2010-10-08 08:32:04 PDT
Comment on attachment 70112 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=70112&action=review > WebCore/inspector/InspectorDOMAgent.cpp:781 > + pair<long, long> breakpoint = m_idToBreakpoint.take(breakpointId); Could you typedef this in header so that we knew what is going on. > WebCore/inspector/front-end/BreakpointManager.js:138 > + if (!(nodeId in this._domPathCache)) Please add // FIXME:
Pavel Podivilov
Comment 3 2010-10-12 02:36:00 PDT
Committed r69567: <http://trac.webkit.org/changeset/69567>
Note You need to log in before you can comment on or make changes to this bug.