Bug 47359 - Don't use the directory structure to gather tests for API tester
Summary: Don't use the directory structure to gather tests for API tester
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-07 10:17 PDT by Sam Weinig
Modified: 2010-10-28 13:17 PDT (History)
2 users (show)

See Also:


Attachments
Patch (20.21 KB, patch)
2010-10-07 10:18 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-10-07 10:17:35 PDT
Don't use the directory structure to gather tests for API tester
Comment 1 Sam Weinig 2010-10-07 10:18:33 PDT
Created attachment 70109 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-07 10:21:09 PDT
Attachment 70109 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/TestWebKitAPI/Test.h:80:  TEST_CLASS_NAME is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-10-07 10:23:05 PDT
Comment on attachment 70109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70109&action=review

> WebKitTools/Scripts/run-api-tests:28
> +#   - Ability to run all tests in a suite.

Didn't you add this?

> WebKitTools/TestWebKitAPI/Test.h:45
> +            TestsController::shared().registerCreateTestFunction(testSuite + "/" + testCase, Register::create);

Perhaps the map key should contain both the suite and the test in a pair?
Comment 4 Eric Seidel (no email) 2010-10-13 12:27:52 PDT
Attachment 70109 [details] was posted by a committer and has review+, assigning to Sam Weinig for commit.
Comment 5 Sam Weinig 2010-10-28 13:17:00 PDT
Fixed in http://trac.webkit.org/changeset/69317.