Bug 47359 – Don't use the directory structure to gather tests for API tester

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Sam Weinig]

Don't use the directory structure to gather tests for API tester

[Sam Weinig]

Created attachment 70109 [details]
Patch

[WebKit Review Bot]

Attachment 70109 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/TestWebKitAPI/Test.h:80:  TEST_CLASS_NAME is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 70109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70109&action=review

> WebKitTools/Scripts/run-api-tests:28
> +#   - Ability to run all tests in a suite.

Didn't you add this?

> WebKitTools/TestWebKitAPI/Test.h:45
> +            TestsController::shared().registerCreateTestFunction(testSuite + "/" + testCase, Register::create);

Perhaps the map key should contain both the suite and the test in a pair?

[Eric Seidel (no email)]

Attachment 70109 [details] was posted by a committer and has review+, assigning to Sam Weinig for commit.

[Sam Weinig]

Fixed in http://trac.webkit.org/changeset/69317.