Bug 47357 - Make findNextLineBreak writing-mode-aware.
Summary: Make findNextLineBreak writing-mode-aware.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46123
  Show dependency treegraph
 
Reported: 2010-10-07 09:51 PDT by Dave Hyatt
Modified: 2010-10-07 10:41 PDT (History)
1 user (show)

See Also:


Attachments
Patch (14.46 KB, patch)
2010-10-07 09:52 PDT, Dave Hyatt
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-10-07 09:51:31 PDT
Make findNextLineBreak writing-mode-aware.
Comment 1 Dave Hyatt 2010-10-07 09:52:51 PDT
Created attachment 70099 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-07 09:54:14 PDT
Attachment 70099 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/rendering/RenderBoxModelObject.h:101:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/rendering/RenderBoxModelObject.h:102:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2010-10-07 09:57:48 PDT
Comment on attachment 70099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70099&action=review

> WebCore/rendering/RenderBlockLineLayout.cpp:1594
> +                    tmpW +=  replacedLogicalWidth;

extra space there

> WebCore/rendering/RenderBoxModelObject.h:102
> +    bool hasInlineDirectionBordersPaddingOrMargin() const { return hasInlineDirectionBordersOrPadding() || marginStart() != 0 || marginEnd() != 0; }
> +    bool hasInlineDirectionBordersOrPadding() const { return borderStart() != 0 || borderEnd() != 0 || paddingStart() != 0 || paddingEnd() != 0; }

You should drop the “!= 0”s per our style.
Comment 4 Dave Hyatt 2010-10-07 10:41:37 PDT
Fixed in r69319.