Bug 47357 – Make findNextLineBreak writing-mode-aware.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

Make findNextLineBreak writing-mode-aware.

[Dave Hyatt]

Created attachment 70099 [details]
Patch

[WebKit Review Bot]

Attachment 70099 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/rendering/RenderBoxModelObject.h:101:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/rendering/RenderBoxModelObject.h:102:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 70099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70099&action=review

> WebCore/rendering/RenderBlockLineLayout.cpp:1594
> +                    tmpW +=  replacedLogicalWidth;

extra space there

> WebCore/rendering/RenderBoxModelObject.h:102
> +    bool hasInlineDirectionBordersPaddingOrMargin() const { return hasInlineDirectionBordersOrPadding() || marginStart() != 0 || marginEnd() != 0; }
> +    bool hasInlineDirectionBordersOrPadding() const { return borderStart() != 0 || borderEnd() != 0 || paddingStart() != 0 || paddingEnd() != 0; }

You should drop the “!= 0”s per our style.

[Dave Hyatt]

Fixed in r69319.