Bug 47346 - Web Inspector: add resource viewer to the network panel.
Summary: Web Inspector: add resource viewer to the network panel.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-07 07:05 PDT by Pavel Feldman
Modified: 2010-10-08 08:20 PDT (History)
11 users (show)

See Also:

Attachments
[IMAGE] Looks with the patch applied. (62.14 KB, image/png)
2010-10-07 07:06 PDT, Pavel Feldman 		no flags Details
[PATCH] Proposed change. (30.76 KB, patch)
2010-10-07 07:08 PDT, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-10-07 07:05:28 PDT 
Patch to follow.
Comment 1 Pavel Feldman 2010-10-07 07:06:44 PDT 
Created attachment 70080 [details]
[IMAGE] Looks with the patch applied.
Comment 2 Pavel Feldman 2010-10-07 07:08:31 PDT 
Created attachment 70081 [details]
[PATCH] Proposed change.
Comment 3 WebKit Review Bot 2010-10-07 07:11:20 PDT 
Attachment 70081 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/inspector/front-end/networkPanel.css:497:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 77 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Yury Semikhatsky 2010-10-08 05:58:14 PDT 
Comment on attachment 70081 [details]
[PATCH] Proposed change.

Please make sure style checker is happy before landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=70081&action=review

> WebCore/inspector/front-end/DataGrid.js:924
> +        var oldPercentLeftColumn = parseFloat(this._headerTableColumnGroup.children[resizer.leftNeighboringColumnID].style.width);
> +        var oldPercentRightColumn = parseFloat(this._headerTableColumnGroup.children[resizer.rightNeighboringColumnID].style.width);

Please remove these two lines.

> WebCore/inspector/front-end/NetworkPanel.js:465
> +        var timelineColumn = this._dataGrid.columns["timeline"];

this._dataGrid.columns["timeline"]; => this._dataGrid.columns.timeline;
Comment 5 Pavel Feldman 2010-10-08 08:20:03 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/inspector/front-end/DataGrid.js
        M       WebCore/inspector/front-end/NetworkPanel.js
        M       WebCore/inspector/front-end/TabbedPane.js
        M       WebCore/inspector/front-end/inspector.css
        M       WebCore/inspector/front-end/networkPanel.css
Committed r69400