Bug 47346 – Web Inspector: add resource viewer to the network panel.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 70080 [details]
[IMAGE] Looks with the patch applied.

[Pavel Feldman]

Created attachment 70081 [details]
[PATCH] Proposed change.

[WebKit Review Bot]

Attachment 70081 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/inspector/front-end/networkPanel.css:497:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 77 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yury Semikhatsky]

Comment on attachment 70081 [details]
[PATCH] Proposed change.

Please make sure style checker is happy before landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=70081&action=review

> WebCore/inspector/front-end/DataGrid.js:924
> +        var oldPercentLeftColumn = parseFloat(this._headerTableColumnGroup.children[resizer.leftNeighboringColumnID].style.width);
> +        var oldPercentRightColumn = parseFloat(this._headerTableColumnGroup.children[resizer.rightNeighboringColumnID].style.width);

Please remove these two lines.

> WebCore/inspector/front-end/NetworkPanel.js:465
> +        var timelineColumn = this._dataGrid.columns["timeline"];

this._dataGrid.columns["timeline"]; => this._dataGrid.columns.timeline;

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/inspector/front-end/DataGrid.js
        M       WebCore/inspector/front-end/NetworkPanel.js
        M       WebCore/inspector/front-end/TabbedPane.js
        M       WebCore/inspector/front-end/inspector.css
        M       WebCore/inspector/front-end/networkPanel.css
Committed r69400