Bug 47344 - [Qt] Show a warning when an injected bundle can't be loaded by QtWebProcess.
Summary: [Qt] Show a warning when an injected bundle can't be loaded by QtWebProcess.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-10-07 06:28 PDT by Jocelyn Turcotte
Modified: 2010-10-15 06:17 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.74 KB, patch)
2010-10-07 06:29 PDT, Jocelyn Turcotte 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2010-10-07 06:28:11 PDT 
[Qt] Show a warning when an injected bundle can't be loaded by QtWebProcess.
Comment 1 Jocelyn Turcotte 2010-10-07 06:29:16 PDT 
Created attachment 70075 [details]
Patch
Comment 2 WebKit Commit Bot 2010-10-14 14:40:05 PDT 
Comment on attachment 70075 [details]
Patch

Rejecting patch 70075 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 70075]" exit_code: 2
Cleaning working directory
Updating working directory
Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=70075&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=47344&ctype=xml
Processing 1 patch from 1 bug.
Processing patch 70075 from bug 47344.
Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/4395037
Comment 3 Jocelyn Turcotte 2010-10-15 01:20:45 PDT 
Comment on attachment 70075 [details]
Patch

Clearing flags, Balazs landed this patch manually a while ago.

Committed r69510: <http://trac.webkit.org/changeset/69510>
Comment 4 Eric Seidel (no email) 2010-10-15 06:17:17 PDT 
We should tell Balzas about "webkit-patch land" or "webkit-patch land-from-bug", as it will automatically close bugs for you. :)

If there are other features you'd like us to add to webkit-patch to make your workflow easier, we'd be happy to.  Just file a bug.  Truly manual landing tends to be error prone.