Bug 47342 - SVGFEColorMatrixElement doesn't support dynamic invalidation
Summary: SVGFEColorMatrixElement doesn't support dynamic invalidation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 45453
  Show dependency tree / graph
 
Reported: 2010-10-07 06:01 PDT by Renata Hodovan
Modified: 2010-10-08 09:53 PDT (History)
3 users (show)

See Also:

Attachments
Patch for feColorMatrix properties (1.50 MB, patch)
2010-10-07 06:41 PDT, Renata Hodovan 		krit: review-
krit: commit-queue-
Details | Formatted Diff | Diff
Patch for feColorMatrix properties (1.33 MB, patch)
2010-10-08 09:05 PDT, Renata Hodovan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Renata Hodovan 2010-10-07 06:01:43 PDT 
SVGFEColorMatrixElement doesn't support dynamic invalidation
Comment 1 Renata Hodovan 2010-10-07 06:41:38 PDT 
Created attachment 70076 [details]
Patch for feColorMatrix properties
Comment 2 Dirk Schulze 2010-10-07 08:19:27 PDT 
Comment on attachment 70076 [details]
Patch for feColorMatrix properties

The same problem like we had on feComposite? The fix looks good of course, but please delete the text in the SVG examples, so that DRT doesn't have useless informations.
Also write more details in the ChangeLog how you solved the problem, that you added svgAttributeChanged and so on.
Comment 3 Renata Hodovan 2010-10-08 09:05:12 PDT 
Created attachment 70254 [details]
Patch for feColorMatrix properties
Comment 4 Andreas Kling 2010-10-08 09:09:14 PDT 
Comment on attachment 70254 [details]
Patch for feColorMatrix properties

LGTM.
Comment 5 WebKit Commit Bot 2010-10-08 09:53:09 PDT 
Comment on attachment 70254 [details]
Patch for feColorMatrix properties

Clearing flags on attachment: 70254

Committed r69409: <http://trac.webkit.org/changeset/69409>
Comment 6 WebKit Commit Bot 2010-10-08 09:53:19 PDT 
All reviewed patches have been landed.  Closing bug.