Bug 47341 – Autocorrection panel regression tests fail on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Roben (:aroben)]

http://trac.webkit.org/changeset/69269 added tests for the autocorrection panel. These tests have been failing on Windows since they were added.

The autocorrection panel is a Mac-only feature. Presumably that means these tests should be in platform/mac, so that they will only run on Mac.

[Adam Roben (:aroben)]

<rdar://problem/8523631>

[Adam Roben (:aroben)]

The other option is to just check in Windows-specific results for the tests. We should do that if we think the tests are meaningful on Windows even though it doesn't have an autocorrection panel feature. Maybe that's the right thing to do, since in the Star Trek future one could be added?

[Adele Peterson]

Sorry for not catching this earlier.  Adam is right - these tests should be moved to platform/mac

[Adam Roben (:aroben)]

(In reply to comment #3)
> Sorry for not catching this earlier.  Adam is right - these tests should be moved to platform/mac

I guess that means you think that is a better option than checking in Windows-specific results?

[Jia Pu]

(In reply to comment #4)
> (In reply to comment #3)
> > Sorry for not catching this earlier.  Adam is right - these tests should be moved to platform/mac
> 
> I guess that means you think that is a better option than checking in Windows-specific results?

The new autocorrection, which is part of AppKit, is only available on Mac. I guess we should just make those tests Mac only.

[Jia Pu]

Created attachment 70138 [details]
Proposed patch (v1)

[Adele Peterson]

Comment on attachment 70138 [details]
Proposed patch (v1)

This skipped lists need to be updated for the new test locations.

[WebKit Commit Bot]

Comment on attachment 70138 [details]
Proposed patch (v1)

Rejecting patch 70138 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2
Last 500 characters of output:
contained 'editing/spelling/autocorrection-removing-underline.html', but no file of that name could be found
Skipped list contained 'editing/spelling/autocorrection-simple.html', but no file of that name could be found
Testing 21488 test cases.
platform/mac/editing/spelling/autocorrection-delete.html -> failed

Exiting early after 1 failures. 17836 tests run.
313.90s total testing time

17835 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
31 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/4190136

[Jia Pu]

Created attachment 70161 [details]
Proposed patch (v1)

Modified Skipped files to reflect the new location of tests.

[Adele Peterson]

Comment on attachment 70161 [details]
Proposed patch (v1)

Brian's going to land this manually.

[Brian Weinstein]

Landed in r69351.