RESOLVED FIXED 47336
[Qt] Update .def file for Symbian 
https://bugs.webkit.org/show_bug.cgi?id=47336
Summary [Qt] Update .def file for Symbian
Keith Kyzivat
Reported 2010-10-07 03:17:17 PDT
The def file for Symbian is out of date. Removes: QWebPage23allowGeolocationRequestEP9QWebFrame QWebPage28viewportConfigurationForSizeE5QSize Adds: DumpRenderTreeSupportQt20dumpHistoryCallbacks DumpRenderTreeSupportQt25dumpVisitedLinksCallbacksEb DumpRenderTreeSupportQt9plainTextERK8QVariant QWebPage28viewportConfigurationForSizeERK5QSize
Attachments
Patch (2.07 KB, patch)
2010-10-07 04:31 PDT, Keith Kyzivat 		no flags
DetailsFormatted DiffDiff
Patch (2.07 KB, patch)
2010-10-07 06:55 PDT, Keith Kyzivat 		hausmann: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Kyzivat
Comment 1 2010-10-07 04:31:47 PDT
Created attachment 70067 [details] Patch
Simon Hausmann
Comment 2 2010-10-07 05:59:57 PDT
Comment on attachment 70067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70067&action=review > WebKit/qt/symbian/eabi/QtWebKitu.def:821 > - _ZNK8QWebPage28viewportConfigurationForSizeE5QSize @ 817 NONAME > + _ZN23DumpRenderTreeSupportQt20dumpHistoryCallbacksEb @ 817 NONAME > + _ZN23DumpRenderTreeSupportQt25dumpVisitedLinksCallbacksEb @ 818 NONAME > + _ZN23DumpRenderTreeSupportQt9plainTextERK8QVariant @ 819 NONAME > + _ZNK8QWebPage28viewportConfigurationForSizeERK5QSize @ 820 NONAME I think instead of replacing 817 with dumpHistoryCallbacks and appending the refreshed viewportConfigurationForSize overoad with ordinal 820, we should do that we did in the qtwebkit-2.1 branch: update the viewportConfigurationForSize signature for ordinal 817.
Keith Kyzivat
Comment 3 2010-10-07 06:33:57 PDT
Good point. I'll update and attach again.
Simon Hausmann
Comment 4 2010-10-07 06:39:45 PDT
*** Bug 47186 has been marked as a duplicate of this bug. ***
Keith Kyzivat
Comment 5 2010-10-07 06:55:39 PDT
Created attachment 70078 [details] Patch
Simon Hausmann
Comment 6 2010-10-07 08:03:51 PDT
Comment on attachment 70078 [details] Patch r=me
Simon Hausmann
Comment 7 2010-10-07 08:10:10 PDT
Committed r69310: <http://trac.webkit.org/changeset/69310>
Note You need to log in before you can comment on or make changes to this bug.