RESOLVED FIXED 47330
Fixing viewport meta tag user-scalable handling 
https://bugs.webkit.org/show_bug.cgi?id=47330
Summary Fixing viewport meta tag user-scalable handling
Luiz Agostini
Reported 2010-10-07 02:11:31 PDT
user-scalable viewport meta tag attribute was not considered when computing viewport attributes.
Attachments
patch (5.25 KB, patch)
2010-10-07 02:22 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
patch (5.29 KB, patch)
2010-10-07 08:33 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2010-10-07 02:22:17 PDT
Created attachment 70057 [details] patch
Kenneth Rohde Christiansen
Comment 2 2010-10-07 07:39:38 PDT
Comment on attachment 70057 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=70057&action=review > WebCore/dom/ViewportArguments.cpp:162 > + if (!args.userScalable) > + result.maximumScale = result.minimumScale = result.initialScale; I think you are missing a result.userScalable = args.userScalable here.
Luiz Agostini
Comment 3 2010-10-07 08:33:57 PDT
Created attachment 70091 [details] patch
WebKit Commit Bot
Comment 4 2010-10-07 10:26:52 PDT
Comment on attachment 70091 [details] patch Clearing flags on attachment: 70091 Committed r69316: <http://trac.webkit.org/changeset/69316>
WebKit Commit Bot
Comment 5 2010-10-07 10:26:56 PDT
All reviewed patches have been landed. Closing bug.
Evan Martin
Comment 6 2010-12-13 14:36:06 PST
This patch changed userScalable from a float to a bool. However, userScalable is initialized from an enum in the constructor, and the enum value is ValueAuto (-1). This produces a compiler warning and probably isn't what you intended. third_party/WebKit/WebCore/dom/ViewportArguments.h(78) : warning C4305: 'initializing' : truncation from '' to 'bool' Should I open a separate bug about this?
Kenneth Rohde Christiansen
Comment 7 2010-12-13 14:37:33 PST
(In reply to comment #6) > This patch changed userScalable from a float to a bool. > However, userScalable is initialized from an enum in the constructor, and the enum value is ValueAuto (-1). This produces a compiler warning and probably isn't what you intended. > > > third_party/WebKit/WebCore/dom/ViewportArguments.h(78) : warning C4305: 'initializing' : truncation from '' to 'bool' > > Should I open a separate bug about this? Oh yeah, please do. Feel free to cc me as.
Note You need to log in before you can comment on or make changes to this bug.