Fixing viewport meta tag user-scalable handling

[Luiz Agostini]

user-scalable viewport meta tag attribute was not considered when computing viewport attributes.

[Luiz Agostini]

Created attachment 70057 [details]
patch

[Kenneth Rohde Christiansen]

Comment on attachment 70057 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70057&action=review

> WebCore/dom/ViewportArguments.cpp:162
> +    if (!args.userScalable)
> +        result.maximumScale = result.minimumScale = result.initialScale;

I think you are missing a result.userScalable = args.userScalable here.

[Luiz Agostini]

Created attachment 70091 [details]
patch

[WebKit Commit Bot]

Comment on attachment 70091 [details]
patch

Clearing flags on attachment: 70091

Committed r69316: <http://trac.webkit.org/changeset/69316>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Evan Martin]

This patch changed userScalable from a float to a bool.
However, userScalable is initialized from an enum in the constructor, and the enum value is ValueAuto (-1).  This produces a compiler warning and probably isn't what you intended.


third_party/WebKit/WebCore/dom/ViewportArguments.h(78) : warning C4305: 'initializing' : truncation from '' to 'bool'

Should I open a separate bug about this?

[Kenneth Rohde Christiansen]

(In reply to comment #6)
> This patch changed userScalable from a float to a bool.
> However, userScalable is initialized from an enum in the constructor, and the enum value is ValueAuto (-1).  This produces a compiler warning and probably isn't what you intended.
> 
> 
> third_party/WebKit/WebCore/dom/ViewportArguments.h(78) : warning C4305: 'initializing' : truncation from '' to 'bool'
> 
> Should I open a separate bug about this?

Oh yeah, please do. Feel free to cc me as.