Bug 47315 - r69181 breaks compilation of WebCore/platform/graphics/filters/FETile.cpp if ENABLE(SVG) is false.
Summary: r69181 breaks compilation of WebCore/platform/graphics/filters/FETile.cpp if ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-06 16:39 PDT by Albert J. Wong
Modified: 2010-12-20 22:52 PST (History)
3 users (show)

See Also:

Attachments
Disable FETime::apply()'s implement if ENABLE(SVG) is false. (1.60 KB, patch)
2010-10-06 16:44 PDT, Albert J. Wong 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Albert J. Wong 2010-10-06 16:39:10 PDT 
In http://trac.webkit.org/changeset/69181, a reference to SVGImageBufferTools::createImageBuffer was added in FETile::apply().  The problem is FETile::apply()'s body is not controlled by ENABLE(SVG), while the declaration of the namespace and functions in SVGImageBufferTools are.  Thus, for builds that have ENABLE(SVG) disabled, this results in a compile error.
Comment 1 Albert J. Wong 2010-10-06 16:40:06 PDT 
Current workaround is to add #if ENABLE(SVG) around the body of FETile::apply() until a better fix can be made.  This should fix compilation in the mean time, and the function doesn't work as is anyways.
Comment 2 Albert J. Wong 2010-10-06 16:44:58 PDT 
Created attachment 70010 [details]
Disable FETime::apply()'s implement if ENABLE(SVG) is false.
Comment 3 Andreas Kling 2010-10-06 16:47:04 PDT 
Comment on attachment 70010 [details]
Disable FETime::apply()'s implement if ENABLE(SVG) is false.

Yuck, but r=me :]
Comment 4 Nikolas Zimmermann 2010-10-06 23:53:38 PDT 
Ouch, it's even a layering violation that we're using SVGImageBufferTools from platform/graphics/filters!
I'm going to have a look at that today.
Comment 5 Dirk Schulze 2010-10-07 00:09:22 PDT 
(In reply to comment #4)
> Ouch, it's even a layering violation that we're using SVGImageBufferTools from platform/graphics/filters!
> I'm going to have a look at that today.

Right forgot this too! Maybe we can make some parts more generic in SVGImageBufferTools SVGImageBufferTools::createImageBuffer(tileRect, tileRect, tileImage, DeviceRGB) is not SVG specific IIRC.
Comment 6 Eric Seidel (no email) 2010-12-14 01:54:23 PST 
What's the status here?
Comment 7 Eric Seidel (no email) 2010-12-20 22:52:13 PST 
r69255.  Please use webkit-patch land to land changes so that bugs are closed after landing.