Looks like there are integer wrap issues here. The upcoming patch detects pathological conditions and returns the empty string. This mirrors the behaviour of e.g. WebCore::base64Encode().
Created attachment 70004 [details] Patch
Comment on attachment 70004 [details] Patch No test?
Comment on attachment 70004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70004&action=review Mr. Barth makes a good observation. Test? > WebCore/ChangeLog:3 > + Reviewed by Reviewed by NOBODY (OOPS!). "Reviewed by Reviewed by"
@abarth: I don't think this can be tested without crashing on 32-bit (virtual address space too small). Even on 64-bit, the test would be at best very slow and at worse prone to exhausting physical memory.
Created attachment 70012 [details] Patch
Comment on attachment 70012 [details] Patch Reasonable explanation about the test.
Comment on attachment 70012 [details] Patch Rejecting patch 70012 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2 Last 500 characters of output: -dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Projects/CommitQueue/LayoutTests Testing 21468 test cases. http/tests/xmlhttprequest/cross-origin-no-credential-prompt.html -> failed Exiting early after 1 failures. 21325 tests run. 566.99s total testing time WARNING:webkitpy.common.system:Called kill_process with a non-existant pid 90163 21324 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 34 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4193122
Seems unrelated; retrying.
Comment on attachment 70012 [details] Patch Rejecting patch 70012 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2 Last 500 characters of output: 0.90 CPU) Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Projects/CommitQueue/LayoutTests Testing 21469 test cases. http/tests/xmlhttprequest/failed-auth.html -> failed Exiting early after 1 failures. 21341 tests run. 565.75s total testing time WARNING:webkitpy.common.system:Called kill_process with a non-existant pid 4291 21340 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 34 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4237080
re cq+, cq-, cq+, cq-, cq+ See defn insanity.
Not sure I follow? I can stop if that's what you saying. We're getting good data as to the current flake rate :)
(In reply to comment #11) > Not sure I follow? I can stop if that's what you saying. > We're getting good data as to the current flake rate :) It was reference to http://www.quotationspage.com/quote/26032.html Meant to be funny that's all.
Comment on attachment 70012 [details] Patch Clearing flags on attachment: 70012 Committed r69275: <http://trac.webkit.org/changeset/69275>
All reviewed patches have been landed. Closing bug.
A victory for insanity! I never knew that was Einstein...