Bug 47307 - Remove support for ANGLE SH_VERSION <= 100
Summary: Remove support for ANGLE SH_VERSION <= 100
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alok Priyadarshi
URL:
Keywords:
Depends on: 47381
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-06 15:08 PDT by Alok Priyadarshi
Modified: 2010-10-12 18:23 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch (2.61 KB, patch)
2010-10-06 15:17 PDT, Alok Priyadarshi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alok Priyadarshi 2010-10-06 15:08:28 PDT
Now that ANGLE version has been rolled to r443 we do not need to support SH_VERSION <= 100.

The code that's been affected is in ${WebKitRoot}/WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp for functions
angleCreateCompilers
angleValidateShaderSource()
Comment 1 Alok Priyadarshi 2010-10-06 15:17:13 PDT
Created attachment 69998 [details]
proposed patch
Comment 2 Kenneth Russell 2010-10-06 15:56:38 PDT
Comment on attachment 69998 [details]
proposed patch

You will need to first roll forward the Chromium deps in WebKit (used to build the DumpRenderTree tool, which depends on this code) to a version containing the rolled-forward ANGLE. I suggest filing a separate bug for that and making this one dependent on it. The file is WebKit/chromium/DEPS, chromium_rev. You can verify that the roll-forward succeeds via "build-webkit --chromium --debug". Mark this r? again once this is done.
Comment 3 Zhenyao Mo 2010-10-07 18:19:20 PDT
have you rolled already?  If not, could you include chroium r61902?
Comment 4 Zhenyao Mo 2010-10-07 19:54:19 PDT
Ignore this.  I just rolled myself.

(In reply to comment #3)
> have you rolled already?  If not, could you include chroium r61902?
Comment 5 Alok Priyadarshi 2010-10-12 15:35:40 PDT
The Chromium DEPS in WebKit has been rolled forward to pull the latest version of ANGLE.
Comment 6 Kenneth Russell 2010-10-12 18:07:20 PDT
Comment on attachment 69998 [details]
proposed patch

Thanks. Looks good to me.
Comment 7 WebKit Commit Bot 2010-10-12 18:23:47 PDT
Comment on attachment 69998 [details]
proposed patch

Clearing flags on attachment: 69998

Committed r69627: <http://trac.webkit.org/changeset/69627>
Comment 8 WebKit Commit Bot 2010-10-12 18:23:52 PDT
All reviewed patches have been landed.  Closing bug.