Bug 47303 - Convert layoutInlineChildren to be block-flow-aware.
Summary: Convert layoutInlineChildren to be block-flow-aware.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46123
  Show dependency treegraph
 
Reported: 2010-10-06 14:16 PDT by Dave Hyatt
Modified: 2010-10-06 14:44 PDT (History)
0 users

See Also:


Attachments
Patch (21.31 KB, patch)
2010-10-06 14:17 PDT, Dave Hyatt
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-10-06 14:16:50 PDT
Convert layoutInlineChildren to be block-flow-aware.  None of the functions it calls are patched yet.
Comment 1 Dave Hyatt 2010-10-06 14:17:42 PDT
Created attachment 69989 [details]
Patch
Comment 2 mitz 2010-10-06 14:29:56 PDT
Comment on attachment 69989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69989&action=review

> WebCore/rendering/RenderBlockLineLayout.cpp:510
> +    int toAdd = borderAfter() + paddingAfter() + scrollbarLogicalHeight();

Need toRename this variable someday.
Comment 3 Dave Hyatt 2010-10-06 14:44:35 PDT
Fixed in r69235.