Bug 47292 - [chromium] Thumbnail generation asserts on zero alpha values.
Summary: [chromium] Thumbnail generation asserts on zero alpha values.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-06 12:15 PDT by Vincent Scheib
Modified: 2010-10-06 18:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.18 KB, patch)
2010-10-06 13:09 PDT, Vincent Scheib 		no flags Details | Formatted Diff | Diff
Patch (2.24 KB, patch)
2010-10-06 13:53 PDT, Vincent Scheib 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Scheib 2010-10-06 12:15:32 PDT 
[chromium] Thumbnail generation asserts on zero alpha values.
Comment 1 Vincent Scheib 2010-10-06 13:09:51 PDT 
Created attachment 69982 [details]
Patch
Comment 2 Vangelis Kokkevis 2010-10-06 13:26:21 PDT 
Comment on attachment 69982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69982&action=review

Otherwise, I agree with the proposed fix.

> WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:288
> +    // Alpha channel on Windows is incorrect when Skia uses ClearType, don't write alpha:

I found the comment confusing.  Did you mean to punctuate differently?  How about:
Alpha channels on windows is incorrect when rendering text with ClearType.  Mask off alpha to maintain proper premultiplied color values in the backbuffer.

or something like that?
Comment 3 Kenneth Russell 2010-10-06 13:44:28 PDT 
Comment on attachment 69982 [details]
Patch

r- to address Vangelis's comments.
Comment 4 Vincent Scheib 2010-10-06 13:53:19 PDT 
Created attachment 69985 [details]
Patch
Comment 5 Kenneth Russell 2010-10-06 13:57:45 PDT 
Comment on attachment 69985 [details]
Patch

OK.
Comment 6 WebKit Commit Bot 2010-10-06 18:26:33 PDT 
Comment on attachment 69985 [details]
Patch

Clearing flags on attachment: 69985

Committed r69266: <http://trac.webkit.org/changeset/69266>
Comment 7 WebKit Commit Bot 2010-10-06 18:26:37 PDT 
All reviewed patches have been landed.  Closing bug.