Bug 47291 - [Mac] [DRT] implement setSpatialNavigationEnabled
Summary: [Mac] [DRT] implement setSpatialNavigationEnabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks: 46905
  Show dependency tree / graph
 
Reported: 2010-10-06 12:14 PDT by Antonio Gomes
Modified: 2010-10-07 21:58 PDT (History)
4 users (show)

See Also:

Attachments
(committed r69373, r=smfr) patch v1 (11.72 KB, patch)
2010-10-07 07:18 PDT, Antonio Gomes 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2010-10-06 12:14:16 PDT 
It would make possible to the current spatial navigation 20 layout tests to run on Mac.

They currently run on Gtk and Qt only.
Comment 1 Antonio Gomes 2010-10-07 07:18:39 PDT 
Created attachment 70082 [details]
(committed r69373, r=smfr) patch v1

Implement setSpatialNavigationEnabled to Mac's DRT. It also required additions to WebPreferencesPrivate and WebView in WebKit/Mac side.
Comment 2 Antonio Gomes 2010-10-07 08:35:05 PDT 
Simon, we need a Mac guy here. Mind to have a review?
Comment 3 Simon Fraser (smfr) 2010-10-07 08:54:06 PDT 
Comment on attachment 70082 [details]
(committed r69373, r=smfr) patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=70082&action=review

> LayoutTests/platform/mac/Skipped:331
> +# Spatial Navigation: test can be affected by font metric differences.
> +fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html
> +fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html

This is unfortunate. Can the tests be rewritten to avoid this?

> WebKitTools/DumpRenderTree/LayoutTestController.cpp:1222
> +    // Has mac implementation.

This comment seems redundant.
Comment 4 Antonio Gomes 2010-10-07 09:22:57 PDT 
(In reply to comment #3)
> (From update of attachment 70082 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70082&action=review
> 
> > LayoutTests/platform/mac/Skipped:331
> > +# Spatial Navigation: test can be affected by font metric differences.
> > +fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html
> > +fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html
> 
> This is unfortunate. Can the tests be rewritten to avoid this?

I am going to do this in a follow up, yes. It has some high priority on my list. I am right now thinking of a smart way we could avoid stuff like this ...

> > WebKitTools/DumpRenderTree/LayoutTestController.cpp:1222
> > +    // Has mac implementation.
> 
> This comment seems redundant.

Many other methods have this, Simon. Ones even have "Has Mac and windows implementation".
Comment 5 Antonio Gomes 2010-10-07 20:57:14 PDT 
Comment on attachment 70082 [details]
(committed r69373, r=smfr) patch v1

Clearing flags on attachment: 70082.

Committed r69373: <http://trac.webkit.org/changeset/69373>
Comment 6 WebKit Review Bot 2010-10-07 21:58:00 PDT 
http://trac.webkit.org/changeset/69373 might have broken SnowLeopard Intel Release (Tests)