Bug 47285 – Remove the block-flow property and update writing-mode

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dave Hyatt]

The latest draft of the writing mode spec kills the block-flow property and just makes writing-mode the property to use.  Update all the code to match the new draft.

[Dave Hyatt]

Created attachment 69968 [details]
Patch

[WebKit Review Bot]

Attachment 69968 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/rendering/style/SVGRenderStyle.h:354:  _writingMode is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 69968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69968&action=review

> WebCore/css/CSSProperty.cpp:45
> +static int resolveToPhysicalProperty(TextDirection direction, WritingMode blockDirection, LogicalBoxSide logicalSide, const int* properties)

I’d rename the variable too.

> WebCore/css/CSSProperty.cpp:152
> +static int resolveToPhysicalProperty(WritingMode blockDirection, LogicalExtent logicalSide, const int* properties)

Ditto.

> WebCore/css/CSSProperty.cpp:159
> +int CSSProperty::resolveDirectionAwareProperty(int propertyID, TextDirection direction, WritingMode blockDirection)

Ditto.

> WebCore/css/CSSValueKeywords.in:762
> +# Standards values from CSS3

Standard?

[Dave Hyatt]

Fixed in r69220.

[WebKit Review Bot]

http://trac.webkit.org/changeset/69220 might have broken SnowLeopard Intel Release (Tests)

[Adam Barth]

(In reply to comment #5)
> http://trac.webkit.org/changeset/69220 might have broken SnowLeopard Intel Release (Tests)

This failure is still on the bots.  Investigating.

[Adam Barth]

http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r69257%20(18889)/fast/css/getComputedStyle/computed-style-without-renderer-pretty-diff.html

Maybe just needs a new baseline?

[Adam Barth]

Landed updated baseline in http://trac.webkit.org/changeset/69263

Mr. Hyatt, was that correct?