Bug 47285 - Remove the block-flow property and update writing-mode
Summary: Remove the block-flow property and update writing-mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46123
  Show dependency tree / graph
 
Reported: 2010-10-06 11:22 PDT by Dave Hyatt
Modified: 2010-10-06 17:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (94.12 KB, patch)
2010-10-06 11:26 PDT, Dave Hyatt 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-10-06 11:22:32 PDT 
The latest draft of the writing mode spec kills the block-flow property and just makes writing-mode the property to use.  Update all the code to match the new draft.
Comment 1 Dave Hyatt 2010-10-06 11:26:42 PDT 
Created attachment 69968 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-06 11:29:25 PDT 
Attachment 69968 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/rendering/style/SVGRenderStyle.h:354:  _writingMode is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2010-10-06 11:32:32 PDT 
Comment on attachment 69968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69968&action=review

> WebCore/css/CSSProperty.cpp:45
> +static int resolveToPhysicalProperty(TextDirection direction, WritingMode blockDirection, LogicalBoxSide logicalSide, const int* properties)

I’d rename the variable too.

> WebCore/css/CSSProperty.cpp:152
> +static int resolveToPhysicalProperty(WritingMode blockDirection, LogicalExtent logicalSide, const int* properties)

Ditto.

> WebCore/css/CSSProperty.cpp:159
> +int CSSProperty::resolveDirectionAwareProperty(int propertyID, TextDirection direction, WritingMode blockDirection)

Ditto.

> WebCore/css/CSSValueKeywords.in:762
> +# Standards values from CSS3

Standard?
Comment 4 Dave Hyatt 2010-10-06 12:02:46 PDT 
Fixed in r69220.
Comment 5 WebKit Review Bot 2010-10-06 13:00:24 PDT 
http://trac.webkit.org/changeset/69220 might have broken SnowLeopard Intel Release (Tests)
Comment 6 Adam Barth 2010-10-06 17:34:22 PDT 
(In reply to comment #5)
> http://trac.webkit.org/changeset/69220 might have broken SnowLeopard Intel Release (Tests)

This failure is still on the bots.  Investigating.
Comment 8 Adam Barth 2010-10-06 17:43:55 PDT 
Landed updated baseline in http://trac.webkit.org/changeset/69263

Mr. Hyatt, was that correct?