Plenty of layout tests have "QMetaObject::invokeMethod: No such method WebCore::SocketStreamHandlePrivate::socketSentData()" messages in stderr in WebKit2. Correct the CamelCase of the socketSentdata() method to fix these warnings in layout tests.
Created attachment 69964 [details] proposed patch
Comment on attachment 69964 [details] proposed patch Looks fine. Are you certain that socketSentdata() is not called from anywhere today?
(In reply to comment #2) > (From update of attachment 69964 [details]) > Looks fine. Are you certain that socketSentdata() is not called from anywhere today? I grepped the whole source, and it isn't used anywhere else. It's only supposed to be used by QMetaObject::invokeMethod, but the name is misspelled.
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 69964 [details] [details]) > > Looks fine. Are you certain that socketSentdata() is not called from anywhere today? > > I grepped the whole source, and it isn't used anywhere else. > It's only supposed to be used by QMetaObject::invokeMethod, but the name is misspelled. ./WebCore/platform/network/qt/SocketStreamHandleQt.cpp:103: QMetaObject::invokeMethod(this, "socketSentData", Qt::QueuedConnection);
Comment on attachment 69964 [details] proposed patch Clearing flags on attachment: 69964 Committed r69221: <http://trac.webkit.org/changeset/69221>
All reviewed patches have been landed. Closing bug.
Created attachment 69978 [details] Patch
Comment on attachment 69978 [details] Patch Sorry for spam on this bug - not certain how I typo-ed the bug number.