Bug 47284 - [Qt] Correct CamelCase of socketSentdata() in SocketStreamHandle
Summary: [Qt] Correct CamelCase of socketSentdata() in SocketStreamHandle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Andras Becsi
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-10-06 11:14 PDT by Andras Becsi
Modified: 2010-10-06 12:57 PDT (History)
5 users (show)

See Also:


Attachments
proposed patch (1.84 KB, patch)
2010-10-06 11:17 PDT, Andras Becsi
no flags Details | Formatted Diff | Diff
Patch (2.18 KB, text/plain)
2010-10-06 12:55 PDT, Vincent Scheib
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2010-10-06 11:14:02 PDT
Plenty of layout tests have "QMetaObject::invokeMethod: No such method WebCore::SocketStreamHandlePrivate::socketSentData()" messages in stderr in WebKit2. Correct the CamelCase of the socketSentdata() method to fix these warnings in layout tests.
Comment 1 Andras Becsi 2010-10-06 11:17:47 PDT
Created attachment 69964 [details]
proposed patch
Comment 2 Kenneth Rohde Christiansen 2010-10-06 11:21:17 PDT
Comment on attachment 69964 [details]
proposed patch

Looks fine. Are you certain that socketSentdata() is not called from anywhere today?
Comment 3 Andras Becsi 2010-10-06 11:27:59 PDT
(In reply to comment #2)
> (From update of attachment 69964 [details])
> Looks fine. Are you certain that socketSentdata() is not called from anywhere today?

I grepped the whole source, and it isn't used anywhere else.
It's only supposed to be used by QMetaObject::invokeMethod, but the name is misspelled.
Comment 4 Andras Becsi 2010-10-06 11:28:57 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 69964 [details] [details])
> > Looks fine. Are you certain that socketSentdata() is not called from anywhere today?
> 
> I grepped the whole source, and it isn't used anywhere else.
> It's only supposed to be used by QMetaObject::invokeMethod, but the name is misspelled.

./WebCore/platform/network/qt/SocketStreamHandleQt.cpp:103:    QMetaObject::invokeMethod(this, "socketSentData", Qt::QueuedConnection);
Comment 5 WebKit Commit Bot 2010-10-06 12:16:13 PDT
Comment on attachment 69964 [details]
proposed patch

Clearing flags on attachment: 69964

Committed r69221: <http://trac.webkit.org/changeset/69221>
Comment 6 WebKit Commit Bot 2010-10-06 12:16:18 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Vincent Scheib 2010-10-06 12:55:33 PDT
Created attachment 69978 [details]
Patch
Comment 8 Vincent Scheib 2010-10-06 12:57:31 PDT
Comment on attachment 69978 [details]
Patch

Sorry for spam on this bug - not certain how I typo-ed the bug number.