Bug 47282 - [CHROMIUM] Crash on failed shader compilation.
Summary: [CHROMIUM] Crash on failed shader compilation.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-06 11:06 PDT by Stephen White
Modified: 2010-10-06 11:23 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.07 KB, patch)
2010-10-06 11:10 PDT, Stephen White 		jamesr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2010-10-06 11:06:11 PDT 
[CHR[CHROMIUM] Crash on failed shader compilation.
Comment 1 Stephen White 2010-10-06 11:07:59 PDT 
When compilation of the canvas2D vertex or fragment shaders fails, we should not crash the renderer.

I noticed this when using --enable-accelerated-2d-canvas with --in-process-webgl.  While this is an unusual combination, it's probably a good idea to make this robust anyway.
Comment 2 Stephen White 2010-10-06 11:10:34 PDT 
Created attachment 69962 [details]
Patch
Comment 3 James Robinson 2010-10-06 11:13:17 PDT 
Comment on attachment 69962 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69962&action=review

Good catch.

> WebCore/platform/graphics/gpu/SharedGraphicsContext3D.h:122
> +    SharedGraphicsContext3D(PassOwnPtr<GraphicsContext3D> context, PassOwnPtr<SolidFillShader> solidFillShader, PassOwnPtr<TexShader> texShader);

nit: don't need to name the params here
Comment 4 Stephen White 2010-10-06 11:23:00 PDT 
Committed r69215: <http://trac.webkit.org/changeset/69215>