Bug 47276 - [Qt] PlatformWebView implementation
Summary: [Qt] PlatformWebView implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 44155
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-06 09:49 PDT by Balazs Kelemen
Modified: 2010-10-06 16:01 PDT (History)
1 user (show)

See Also:


Attachments
Patch (4.19 KB, patch)
2010-10-06 09:53 PDT, Balazs Kelemen
kenneth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2010-10-06 09:49:15 PDT
Another step for a working WTR, the WebView.
Comment 1 Balazs Kelemen 2010-10-06 09:53:18 PDT
Created attachment 69951 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2010-10-06 09:58:47 PDT
Comment on attachment 69951 [details]
Patch

Generally looks good to me. Is the graphics view freeing the scene?
Comment 3 Balazs Kelemen 2010-10-06 10:13:44 PDT
(In reply to comment #2)
> (From update of attachment 69951 [details])
> Generally looks good to me. Is the graphics view freeing the scene?

Yes, because it's parent is the WebView.
Comment 4 Balazs Kelemen 2010-10-06 14:30:18 PDT
I will land that after 44155 lands because otherwise that would not apply.
Comment 5 Andras Becsi 2010-10-06 16:01:12 PDT
Committed r69248: <http://trac.webkit.org/changeset/69248>