RESOLVED FIXED 47255
[GTK] Remove more warnings from the g-i scanner run 
https://bugs.webkit.org/show_bug.cgi?id=47255
Summary [GTK] Remove more warnings from the g-i scanner run
Xan Lopez
Reported 2010-10-06 04:22:48 PDT
This gets rid of *almost* all the warnings that are not coming from the DOM bindings (there's a couple left that I can't figure out). In no particular order: - Name the parameters correctly in the gtk-doc blurb, they have to match the name used in the method. Also, make the parameter name in the header by in sync with the one in the definition. - Add a few files that were missing to the scanner run (mostly stuff in the build dir). - Write a couple of missing docs.
Attachments
warnings.diff (62.20 KB, patch)
2010-10-06 04:27 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2010-10-06 04:27:41 PDT
Created attachment 69920 [details] warnings.diff
WebKit Review Bot
Comment 2 2010-10-06 04:34:41 PDT
Attachment 69920 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 Last 3072 characters of output: efore ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:264: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:267: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:270: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:273: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:276: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:279: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:282: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:285: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:289: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:292: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:295: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:299: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:302: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:305: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:308: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:312: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:315: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:319: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:322: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:326: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:329: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:332: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:335: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:352: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:356: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:364: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:367: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:382: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:386: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 58 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gustavo Noronha (kov)
Comment 3 2010-10-11 14:15:48 PDT
Comment on attachment 69920 [details] warnings.diff Hrm. =)
Xan Lopez
Comment 4 2010-10-13 08:43:50 PDT
Comment on attachment 69920 [details] warnings.diff Landed as r69655.
Xan Lopez
Comment 5 2010-10-13 08:44:06 PDT
Closing.
Note You need to log in before you can comment on or make changes to this bug.