Bug 47250 – Web Inspector: test that uncaught exceptions have stack trace when inspector is open

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Web Inspector: test that uncaught exceptions have stack trace when inspector is open

[Yury Semikhatsky]

Created attachment 69909 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 69909 [details]
Patch

Clearing flags on attachment: 69909

Committed r69190: <http://trac.webkit.org/changeset/69190>

[Yury Semikhatsky]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

Comment on attachment 69909 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69909&action=review

> LayoutTests/http/tests/inspector/console-tests2.js:29
>  \ No newline at end of file

Nit: Newline! If you remember next time you update the file =).

Nice test.

[Adam Barth]

This patch does not have expected results on non-Chromium ports:

http://trac.webkit.org/changeset/69190

Can you please add some?  kthxsbye

[Joseph Pecoraro]

I'm still updating (and would have to build) before I could verify. But the snow leopard bots produced the following results:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r69440%20(19029)/inspector/console-uncaught-exception-actual.txt

I'm guessing the differences are jsc/v8 related.

[Joseph Pecoraro]

Created attachment 70342 [details]
[PATCH] General Expected Results

Looks like git was smarter than me. I ran and generated the expected results on my snow leopard machine.
I checked and noticed gtk's results (added since this landed) were identical and removed them. Git
considers it just a file move. That works for me.

[Joseph Pecoraro]

I don't have a windows machine to test on, but I assume it should work
fine with these results. There aren't any windows platform specific
results for inspector tests.

[Joseph Pecoraro]

Committed r69441
	D	LayoutTests/platform/gtk/inspector/console-uncaught-exception-expected.txt
	A	LayoutTests/inspector/console-uncaught-exception-expected.txt
	M	LayoutTests/ChangeLog
r69441 = 4bf3c909c6f049dc3bf507926d7b11a66f58b386
http://trac.webkit.org/changeset/69441

[Joseph Pecoraro]

Comment on attachment 70342 [details]
[PATCH] General Expected Results

Removed the cq? flag, since this landed a while ago.