RESOLVED FIXED 47247
[Chromium] WebIDBKeyRange should handle null left/right pointers 
https://bugs.webkit.org/show_bug.cgi?id=47247
Summary [Chromium] WebIDBKeyRange should handle null left/right pointers
Jeremy Orlow
Reported 2010-10-05 22:17:10 PDT
[Chromium] WebIDBKeyRange should handle null left/right pointers
Attachments
Patch (1.93 KB, patch)
2010-10-05 22:18 PDT, Jeremy Orlow 		japhet: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-10-05 22:18:02 PDT
Created attachment 69888 [details] Patch
Nate Chapin
Comment 2 2010-10-06 09:19:26 PDT
Comment on attachment 69888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69888&action=review > WebKit/chromium/src/WebIDBKeyRange.cpp:44 > + if (left.type() == WebIDBKey::InvalidType && right.type() == WebIDBKey::InvalidType) Will it ever be the case that only one of these is invalid? LGTM otherwise.
Jeremy Orlow
Comment 3 2010-10-06 09:25:58 PDT
Comment on attachment 69888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69888&action=review >> WebKit/chromium/src/WebIDBKeyRange.cpp:44 >> + if (left.type() == WebIDBKey::InvalidType && right.type() == WebIDBKey::InvalidType) > > Will it ever be the case that only one of these is invalid? > > LGTM otherwise. Yeah. You can have items that are either left bounded or right bounded (but not both).
Jeremy Orlow
Comment 4 2010-10-06 10:21:36 PDT
Committed r69208: <http://trac.webkit.org/changeset/69208>
Note You need to log in before you can comment on or make changes to this bug.