Bug 47247 - [Chromium] WebIDBKeyRange should handle null left/right pointers
Summary: [Chromium] WebIDBKeyRange should handle null left/right pointers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jeremy Orlow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-05 22:17 PDT by Jeremy Orlow
Modified: 2010-10-06 10:21 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.93 KB, patch)
2010-10-05 22:18 PDT, Jeremy Orlow 		japhet: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2010-10-05 22:17:10 PDT 
[Chromium] WebIDBKeyRange should handle null left/right pointers
Comment 1 Jeremy Orlow 2010-10-05 22:18:02 PDT 
Created attachment 69888 [details]
Patch
Comment 2 Nate Chapin 2010-10-06 09:19:26 PDT 
Comment on attachment 69888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69888&action=review

> WebKit/chromium/src/WebIDBKeyRange.cpp:44
> +    if (left.type() == WebIDBKey::InvalidType && right.type() == WebIDBKey::InvalidType)

Will it ever be the case that only one of these is invalid?

LGTM otherwise.
Comment 3 Jeremy Orlow 2010-10-06 09:25:58 PDT 
Comment on attachment 69888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69888&action=review

>> WebKit/chromium/src/WebIDBKeyRange.cpp:44
>> +    if (left.type() == WebIDBKey::InvalidType && right.type() == WebIDBKey::InvalidType)
> 
> Will it ever be the case that only one of these is invalid?
> 
> LGTM otherwise.

Yeah.  You can have items that are either left bounded or right bounded (but not both).
Comment 4 Jeremy Orlow 2010-10-06 10:21:36 PDT 
Committed r69208: <http://trac.webkit.org/changeset/69208>