Bug 47242 – [chromium] DRT assertion w/accel 2D canvas in PlatformContextSkia

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Kenneth Russell]

fast/canvas/canvas-putImageData.html is failing when run in DRT with --enable-accelerated-compositing --enable-accelerated-2d-canvas due to the following assertion failure:

Program received signal SIGSEGV, Segmentation fault.
0x0000000000c331bb in WebCore::PlatformContextSkia::markDirtyRect (this=0x7fffec567900, rect=...) at WebCore/platform/graphics/skia/PlatformContextSkia.cpp:814
814	        ASSERT_NOT_REACHED();
(gdb) where
#0  0x0000000000c331bb in WebCore::PlatformContextSkia::markDirtyRect (this=0x7fffec567900, rect=...) at WebCore/platform/graphics/skia/PlatformContextSkia.cpp:814
#1  0x0000000000c2aa23 in WebCore::GraphicsContext::markDirtyRect (this=0x7ffff7e92560, rect=...) at WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:1257
#2  0x00000000005f252b in WebCore::CanvasRenderingContext2D::didDraw (this=0x7fffec510420, r=..., options=0) at WebCore/html/canvas/CanvasRenderingContext2D.cpp:1495
#3  0x00000000005f2fb3 in WebCore::CanvasRenderingContext2D::putImageData (this=0x7fffec510420, data=0x7fffec5c85c0, dx=0, dy=0, dirtyX=0, dirtyY=0, dirtyWidth=100, 
    dirtyHeight=100, ec=@0x7fffffffbeac) at WebCore/html/canvas/CanvasRenderingContext2D.cpp:1626
#4  0x00000000005f2bf5 in WebCore::CanvasRenderingContext2D::putImageData (this=0x7fffec510420, data=0x7fffec5c85c0, dx=0, dy=0, ec=@0x7fffffffbeac)
    at WebCore/html/canvas/CanvasRenderingContext2D.cpp:1585
...

m_backingStoreState is None at this point.

[James Robinson]

The issue is we aren't calling prepareForSoftwareDraw() before doing the putImageData.  Patch incoming.

[James Robinson]

Created attachment 69879 [details]
Patch

[Stephen White]

(In reply to comment #2)
> Created an attachment (id=69879) [details]
> Patch

Looks good, but I'm not a reviewer.

[Kenneth Russell]

Comment on attachment 69879 [details]
Patch

Looks good to me.

[James Robinson]

Committed r69227: <http://trac.webkit.org/changeset/69227>