Bug 47227 - [chromium] Minor naming cleanup in WebDragData, part 2
Summary: [chromium] Minor naming cleanup in WebDragData, part 2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Daniel Cheng
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-05 16:07 PDT by Daniel Cheng
Modified: 2010-10-07 15:04 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.46 KB, patch)
2010-10-05 16:09 PDT, Daniel Cheng
tony: review+
tony: commit-queue-
Details | Formatted Diff | Diff
Patch (5.47 KB, patch)
2010-10-07 12:59 PDT, Daniel Cheng
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Cheng 2010-10-05 16:07:08 PDT
Now that Chromium uses the new renamed methods, delete the old deprecated methods.
Comment 1 Daniel Cheng 2010-10-05 16:09:22 PDT
Created attachment 69861 [details]
Patch
Comment 2 Tony Chang 2010-10-05 16:13:50 PDT
Comment on attachment 69861 [details]
Patch

LGTM, but I will hold off on the r+ cq+ while the EWS bot tries the patch.
Comment 3 Tony Chang 2010-10-06 09:25:00 PDT
Not sure why the ews bot didn't compile this on cr-linux overnight.

Anyway, I'm going to land manually for dcheng.
Comment 4 Tony Chang 2010-10-06 09:25:56 PDT
Oh, nothing is building on cr-linux:
http://webkit-commit-queue.appspot.com/queue-status/chromium-ews
Comment 5 Tony Chang 2010-10-06 09:46:40 PDT
Meh, the bug reference in the ChangeLog was wrong so bug 46937 got updated instead.

http://trac.webkit.org/changeset/69202
Comment 6 Tony Chang 2010-10-06 10:15:19 PDT
Rolled out in r69207.  Reopening.

webkit/tools/test_shell/event_sending_controller.cc: In member function ‘void EventSendingController::beginDragWithFiles(const CppArgumentList&, CppVariant*)’:
webkit/tools/test_shell/event_sending_controller.cc:815:error: ‘class WebKit::WebDragData’ has no member named ‘appendToFileNames’
make: *** [out/Release/obj.target/test_shell_common/webkit/tools/test_shell/event_sending_controller.o] Error 1
webkit/tools/test_shell/test_webview_delegate.cc: In function ‘void<unnamed>::AddDRTFakeFileToDataObject(WebKit::WebDragData*)’:
webkit/tools/test_shell/test_webview_delegate.cc:180:error: ‘class WebKit::WebDragData’ has no member named ‘appendToFileNames’
make: *** [out/Release/obj.target/test_shell_common/webkit/tools/test_shell/test_webview_delegate.o] Error 1
Comment 7 Daniel Cheng 2010-10-07 12:59:38 PDT
Created attachment 70137 [details]
Patch

Another patch checked into Chrome, and once again, it built locally. Hopefully it actually works this time.

(I updated the bug URL in the ChangeLogs as well)
Comment 8 WebKit Commit Bot 2010-10-07 15:04:32 PDT
Comment on attachment 70137 [details]
Patch

Clearing flags on attachment: 70137

Committed r69346: <http://trac.webkit.org/changeset/69346>
Comment 9 WebKit Commit Bot 2010-10-07 15:04:37 PDT
All reviewed patches have been landed.  Closing bug.