Bug 47216 - [chromium] Implement layerTreeAsText in DumpRenderTree
Summary: [chromium] Implement layerTreeAsText in DumpRenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-05 14:48 PDT by Kenneth Russell
Modified: 2010-10-05 16:00 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.33 KB, patch)
2010-10-05 14:52 PDT, Kenneth Russell
tony: review+
kbr: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-10-05 14:48:50 PDT
Several of the compositing layout tests rely on LayoutTestController.layerTreeAsText(), which is not currently implemented in DumpRenderTree.
Comment 1 Kenneth Russell 2010-10-05 14:52:58 PDT
Created attachment 69850 [details]
Patch

From the ChangeLog:

Plumbed Frame::layerTreeAsText through Chromium's WebKit API to make it callable from DumpRenderTree.

No new tests; verified with existing compositor layout tests.
Comment 2 Tony Chang 2010-10-05 15:00:21 PDT
Comment on attachment 69850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69850&action=review

> WebKit/chromium/public/WebFrame.h:554
> +    virtual WebString layerTreeAsText() const = 0;

Nit: Please document this method with a comment.
Comment 3 Kenneth Russell 2010-10-05 15:08:47 PDT
(In reply to comment #2)
> (From update of attachment 69850 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69850&action=review
> 
> > WebKit/chromium/public/WebFrame.h:554
> > +    virtual WebString layerTreeAsText() const = 0;
> 
> Nit: Please document this method with a comment.

Will add comment during landing.
Comment 4 Kenneth Russell 2010-10-05 15:11:52 PDT
Committed r69151: <http://trac.webkit.org/changeset/69151>
Comment 5 Darin Fisher (:fishd, Google) 2010-10-05 15:45:57 PDT
Comment on attachment 69850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69850&action=review

>>> WebKit/chromium/public/WebFrame.h:554
>>> +    virtual WebString layerTreeAsText() const = 0;
>> 
>> Nit: Please document this method with a comment.
> 
> Will add comment during landing.

nit: please preserve the new line before the "protected:" label
Comment 6 Kenneth Russell 2010-10-05 16:00:50 PDT
(In reply to comment #5)
> (From update of attachment 69850 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69850&action=review
> 
> >>> WebKit/chromium/public/WebFrame.h:554
> >>> +    virtual WebString layerTreeAsText() const = 0;
> >> 
> >> Nit: Please document this method with a comment.
> > 
> > Will add comment during landing.
> 
> nit: please preserve the new line before the "protected:" label

Newline re-added in r69157.