RESOLVED FIXED 47216
[chromium] Implement layerTreeAsText in DumpRenderTree 
https://bugs.webkit.org/show_bug.cgi?id=47216
Summary [chromium] Implement layerTreeAsText in DumpRenderTree
Kenneth Russell
Reported 2010-10-05 14:48:50 PDT
Several of the compositing layout tests rely on LayoutTestController.layerTreeAsText(), which is not currently implemented in DumpRenderTree.
Attachments
Patch (5.33 KB, patch)
2010-10-05 14:52 PDT, Kenneth Russell 		tony: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-10-05 14:52:58 PDT
Created attachment 69850 [details] Patch From the ChangeLog: Plumbed Frame::layerTreeAsText through Chromium's WebKit API to make it callable from DumpRenderTree. No new tests; verified with existing compositor layout tests.
Tony Chang
Comment 2 2010-10-05 15:00:21 PDT
Comment on attachment 69850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69850&action=review > WebKit/chromium/public/WebFrame.h:554 > + virtual WebString layerTreeAsText() const = 0; Nit: Please document this method with a comment.
Kenneth Russell
Comment 3 2010-10-05 15:08:47 PDT
(In reply to comment #2) > (From update of attachment 69850 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=69850&action=review > > > WebKit/chromium/public/WebFrame.h:554 > > + virtual WebString layerTreeAsText() const = 0; > > Nit: Please document this method with a comment. Will add comment during landing.
Kenneth Russell
Comment 4 2010-10-05 15:11:52 PDT
Committed r69151: <http://trac.webkit.org/changeset/69151>
Darin Fisher (:fishd, Google)
Comment 5 2010-10-05 15:45:57 PDT
Comment on attachment 69850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69850&action=review >>> WebKit/chromium/public/WebFrame.h:554 >>> + virtual WebString layerTreeAsText() const = 0; >> >> Nit: Please document this method with a comment. > > Will add comment during landing. nit: please preserve the new line before the "protected:" label
Kenneth Russell
Comment 6 2010-10-05 16:00:50 PDT
(In reply to comment #5) > (From update of attachment 69850 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=69850&action=review > > >>> WebKit/chromium/public/WebFrame.h:554 > >>> + virtual WebString layerTreeAsText() const = 0; > >> > >> Nit: Please document this method with a comment. > > > > Will add comment during landing. > > nit: please preserve the new line before the "protected:" label Newline re-added in r69157.
Note You need to log in before you can comment on or make changes to this bug.