Bug 47195 - [Qt] Duplicated code in QWebPagePrivate
Summary: [Qt] Duplicated code in QWebPagePrivate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-05 10:34 PDT by Ragner Magalhaes
Modified: 2010-10-06 11:53 PDT (History)
3 users (show)

See Also:

Attachments
Patch 01 (13.83 KB, patch)
2010-10-05 11:35 PDT, Ragner Magalhaes 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ragner Magalhaes 2010-10-05 10:34:16 PDT 
In QWebPagePrivate class has some duplicated methods for mouse events from QGraphicsView and QWidget.
Comment 1 Ragner Magalhaes 2010-10-05 11:35:21 PDT 
Created attachment 69817 [details]
Patch 01
Comment 2 Antonio Gomes 2010-10-05 11:38:26 PDT 
Comment on attachment 69817 [details]
Patch 01

This is a great thing! r=me, but please wait kling, simon or kenneth to look at it, and set cq+
Comment 3 Ragner Magalhaes 2010-10-05 11:41:30 PDT 
(In reply to comment #2)
> (From update of attachment 69817 [details])
> This is a great thing! r=me, but please wait kling, simon or kenneth to look at it, and set cq+
Ok,
waiting :P
Comment 4 Andreas Kling 2010-10-05 11:42:41 PDT 
I like it.
Comment 5 WebKit Commit Bot 2010-10-06 11:53:49 PDT 
Comment on attachment 69817 [details]
Patch 01

Clearing flags on attachment: 69817

Committed r69217: <http://trac.webkit.org/changeset/69217>
Comment 6 WebKit Commit Bot 2010-10-06 11:53:54 PDT 
All reviewed patches have been landed.  Closing bug.