Bug 47193 - [chromium] 51304 GPU compositor resorts to "slow" text rendering for base page layer
Summary: [chromium] 51304 GPU compositor resorts to "slow" text rendering for base pag...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Vincent Scheib
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-05 10:28 PDT by Vincent Scheib
Modified: 2010-10-05 13:59 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.59 KB, patch)
2010-10-05 10:34 PDT, Vincent Scheib 		no flags Details | Formatted Diff | Diff
Patch (2.70 KB, patch)
2010-10-05 11:38 PDT, Vincent Scheib 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Scheib 2010-10-05 10:28:34 PDT 
[chromium] 51304 GPU compositor resorts to "slow" text rendering for base page layer
Comment 1 Vincent Scheib 2010-10-05 10:34:31 PDT 
Created attachment 69806 [details]
Patch
Comment 2 Vangelis Kokkevis 2010-10-05 11:12:50 PDT 
Comment on attachment 69806 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69806&action=review

I think an inline comment about blending would help us remember why it's done the way it is.  Otherwise looks good!

> WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:206
> +    GLC(m_context, m_context->disable(GraphicsContext3D::BLEND));

Can you please add a comment here saying that we need to render the root layer without blending to get subpixel antialised text displaying correctly?  That way we won't forget why we need to flip blending on and off.
Comment 3 Vincent Scheib 2010-10-05 11:38:58 PDT 
Created attachment 69818 [details]
Patch
Comment 4 Kenneth Russell 2010-10-05 12:25:21 PDT 
Comment on attachment 69818 [details]
Patch

Looks fine to me; confirmed with Vincent offline that CSS 3D tests with translucent layers continue to render correctly.
Comment 5 WebKit Commit Bot 2010-10-05 13:59:28 PDT 
Comment on attachment 69818 [details]
Patch

Clearing flags on attachment: 69818

Committed r69144: <http://trac.webkit.org/changeset/69144>
Comment 6 WebKit Commit Bot 2010-10-05 13:59:33 PDT 
All reviewed patches have been landed.  Closing bug.