Bug 47189 - Ignore whitespace in base64 decoding of data URL
Summary: Ignore whitespace in base64 decoding of data URL
Status: RESOLVED DUPLICATE of bug 41462
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-05 10:07 PDT by Kwang Yul Seo
Modified: 2010-10-06 10:19 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.81 KB, patch)
2010-10-05 10:09 PDT, Kwang Yul Seo
darin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-10-05 10:07:26 PDT
RFC2397 (The "data" URL scheme) refers to RFC 2045 (MIME) for base64 decoding and RFC 2045 states: All line breaks or other characters not found in Table 1 must be ignored by decoding software. Acid3 test 97 tests this.

Pass IgnoreWhitespace to base64Decode function to ignore whitespace in base64 decoding.
Comment 1 Kwang Yul Seo 2010-10-05 10:09:08 PDT
Created attachment 69803 [details]
Patch
Comment 2 Kwang Yul Seo 2010-10-05 21:06:25 PDT
CC'ing Alp Toker for review.
Comment 3 Darin Adler 2010-10-06 10:08:22 PDT
Comment on attachment 69803 [details]
Patch

This helps only the CURL port. We want to move data URL handling out of ResourceHandle entirely and share it between all platforms.
Comment 4 WebKit Commit Bot 2010-10-06 10:11:05 PDT
Comment on attachment 69803 [details]
Patch

Rejecting patch 69803 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 69803]" exit_code: 2
Cleaning working directory
Updating working directory
Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=69803&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=47189&ctype=xml
Processing 1 patch from 1 bug.
Processing patch 69803 from bug 47189.
Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/4221115
Comment 5 Kwang Yul Seo 2010-10-06 10:14:59 PDT
(In reply to comment #3)
> (From update of attachment 69803 [details])
> This helps only the CURL port. We want to move data URL handling out of ResourceHandle entirely and share it between all platforms.

Yes, I agree. Brew MP http backend (not yet upstreamed) also copied data URL code from the CURL port.
Comment 6 Kwang Yul Seo 2010-10-06 10:19:22 PDT
Done in bug 41462

*** This bug has been marked as a duplicate of bug 41462 ***