Bug 47180 - SVGTextLayoutAttributesBuilder: "XValue" and "YValue" clash with X11 macros
Summary: SVGTextLayoutAttributesBuilder: "XValue" and "YValue" clash with X11 macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-10-05 08:25 PDT by Andreas Kling
Modified: 2010-10-08 07:36 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (3.79 KB, patch)
2010-10-08 02:43 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-10-05 08:25:12 PDT 
Xutil.h defines both "XValue" and "YValue", so including that before SVGTextLayoutAttributesBuilder.h breaks compilation.
It would be neat if we could avoid these names (but there's always the npruntime_internal.h approach of manually undeffing things..)

This currently breaks Qt+V8 compilation.
Comment 1 Nikolas Zimmermann 2010-10-08 02:36:27 PDT 
Ok, just rename to XValueAttribute or sth. similar, no problem.
Comment 2 Andreas Kling 2010-10-08 02:43:02 PDT 
Created attachment 70217 [details]
Proposed patch
Comment 3 Nikolas Zimmermann 2010-10-08 02:45:57 PDT 
Comment on attachment 70217 [details]
Proposed patch

r=me.
Comment 4 Andreas Kling 2010-10-08 07:36:40 PDT 
Comment on attachment 70217 [details]
Proposed patch

Clearing flags on attachment: 70217

Committed r69399: <http://trac.webkit.org/changeset/69399>
Comment 5 Andreas Kling 2010-10-08 07:36:50 PDT 
All reviewed patches have been landed.  Closing bug.