Bug 47179 - Don't include JavaScriptCore/config.h from command line
Summary: Don't include JavaScriptCore/config.h from command line
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-05 08:11 PDT by Kristian Monsen
Modified: 2010-10-05 08:54 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch (1.88 KB, patch)
2010-10-05 08:14 PDT, Kristian Monsen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kristian Monsen 2010-10-05 08:11:17 PDT
JavaScriptCore/config.h were included from WebCorePrefix.h. This is included on the command line, which means it is included before any content in a cpp file. It also violates the rules in WebCorePrefix.h

Moving the include to WebCore/config.h, so if one is included both will be.
Comment 1 Kristian Monsen 2010-10-05 08:14:14 PDT
Created attachment 69784 [details]
Proposed patch
Comment 2 Steve Block 2010-10-05 08:22:35 PDT
Comment on attachment 69784 [details]
Proposed patch

r=me
Comment 3 WebKit Commit Bot 2010-10-05 08:53:55 PDT
Comment on attachment 69784 [details]
Proposed patch

Clearing flags on attachment: 69784

Committed r69112: <http://trac.webkit.org/changeset/69112>
Comment 4 WebKit Commit Bot 2010-10-05 08:54:00 PDT
All reviewed patches have been landed.  Closing bug.