Bug 47168 – [Qt] WebKit2 should support focusing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Kimmo Kinnunen]

Qt WebKit2 API should support setting and unsetting focus for the QGraphicsWKView. Otherwise input/text areas don't display caret.

[Kimmo Kinnunen]

Created attachment 69781 [details]
Patch to set focus and active flags when qgraphicswkitem gets focused.

[Andreas Kling]

Comment on attachment 69781 [details]
Patch to set focus and active flags when qgraphicswkitem gets focused.

LGTM.

[WebKit Commit Bot]

Comment on attachment 69781 [details]
Patch to set focus and active flags when qgraphicswkitem gets focused.

Rejecting patch 69781 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2
Last 500 characters of output:
l tests successful.
Files=14, Tests=304,  1 wallclock secs ( 0.72 cusr +  0.17 csys =  0.89 CPU)
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Projects/CommitQueue/LayoutTests
Testing 21469 test cases.
java/lc3/JSObject/ToObject-001.html -> failed

Exiting early after 1 failures. 17533 tests run.
282.75s total testing time

17532 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
28 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/4255039

[Kimmo Kinnunen]

Comment on attachment 69781 [details]
Patch to set focus and active flags when qgraphicswkitem gets focused.

can somebody re-cq+ ? I think the cq failure was unrelated to this patch.

[Andreas Kling]

Comment on attachment 69781 [details]
Patch to set focus and active flags when qgraphicswkitem gets focused.

Let's try that again.

[WebKit Commit Bot]

Comment on attachment 69781 [details]
Patch to set focus and active flags when qgraphicswkitem gets focused.

Clearing flags on attachment: 69781

Committed r69391: <http://trac.webkit.org/changeset/69391>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.